From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: Sun, 20 Jul 2014 19:11:40 -0400
Message-ID: <18851.1405897900@sss.pgh.pa.us> (raw)
In-Reply-To: <18673.1405897470@sss.pgh.pa.us>
References: <20140720200225.GA5974@alap3.anarazel.de>
<13755.1405887378@sss.pgh.pa.us>
<20140720204852.GB5974@alap3.anarazel.de>
<15685.1405891368@sss.pgh.pa.us>
<20140720213258.GD5974@alap3.anarazel.de>
<16274.1405892584@sss.pgh.pa.us>
<20140720220253.GE5974@alap3.anarazel.de>
<17255.1405894611@sss.pgh.pa.us>
<20140720223010.GF5974@alap3.anarazel.de>
<17935.1405895946@sss.pgh.pa.us>
<20140720225653.GG5974@alap3.anarazel.de>
<18673.1405897470@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
I wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
>> If any *single* full table vacuum after that calls
>> vac_update_datfrozenxid() which just needs its datfrozenxid advance by
>> one we're in trouble: vac_truncate_clog() will be called with minMulti =
>> GetOldestMultiXactId().
> Uh, no, the cutoff is GetOldestMultiXactId minus
> vacuum_multixact_freeze_min_age (or the autovac equivalent).
Oh, wait, I see what you're on about: that cutoff doesn't constrain
the global value computed by vac_truncate_clog. Hmm.
I wonder whether we should change vac_update_relstats so that it only
applies the "relminxid mustn't go backwards" rule as long as relminxid
is sane, ie, not in the future. If it is in the future, forcibly update
it to the cutoff we actually used. Likewise for relminmxid. And I guess
we'd need a similar rule for updating datmin(m)xid.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
In-Reply-To: <18851.1405897900@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox