pg.ddx.io pgsql-bugs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
BUG #18890: /src/timezone/localtime.c condition always false 2+ messages / 2 participants [nested] [flat]
* BUG #18890: /src/timezone/localtime.c condition always false @ 2025-04-10 16:44 PG Bug reporting form <noreply@postgresql.org> 2025-04-10 18:02 ` Re: BUG #18890: /src/timezone/localtime.c condition always false Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 2+ messages in thread From: PG Bug reporting form @ 2025-04-10 16:44 UTC (permalink / raw) To: pgsql-bugs@lists.postgresql.org; +Cc: dan-eli@mail.ru The following bug has been logged on the website: Bug reference: 18890 Logged by: Daniel Elishakov Email address: dan-eli@mail.ru PostgreSQL version: 17.4 Operating system: Ubuntu 20.04 Description: On line 223 there is a check of string 'name' and in this case it is initiallized and then is being checked for null once more with no reason. The code becomes quite buggy. ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: BUG #18890: /src/timezone/localtime.c condition always false 2025-04-10 16:44 BUG #18890: /src/timezone/localtime.c condition always false PG Bug reporting form <noreply@postgresql.org> @ 2025-04-10 18:02 ` Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2025-04-10 18:02 UTC (permalink / raw) To: dan-eli@mail.ru; +Cc: pgsql-bugs@lists.postgresql.org PG Bug reporting form <noreply@postgresql.org> writes: > On line 223 there is a check of string 'name' and in this case it is > initiallized and then is being checked for null once more with no reason. This code is taken from the upstream tzcode distribution, in which TZDEFAULT can be NULL. (Or so I assume anyway without having looked.) I'm disinclined to diverge from their code just to satisfy some static analyzer complaining about useless code --- any reasonable C compiler will discard that code, so it's not a problem. > The code becomes quite buggy. If there is actually a bug here, I'm not seeing it. regards, tom lane ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-04-10 18:02 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-04-10 16:44 BUG #18890: /src/timezone/localtime.c condition always false PG Bug reporting form <noreply@postgresql.org> 2025-04-10 18:02 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox