pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: clemens.ruck@t-online.de
Subject: BUG #18901: Bug in Perl-Script "src/backend/nodes/gen_node_support.pl"
Date: Tue, 22 Apr 2025 16:39:46 +0000
Message-ID: <18901-424272abe01357e6@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      18901
Logged by:          Clemens Ruck
Email address:      clemens.ruck@t-online.de
PostgreSQL version: 17.4
Operating system:   Ubuntu 22.04
Description:        

While implementing some things in my own branch of the Postgres 17.4 branch
(REL_17_STABLE), I encountered a possible bug in the perl script
"src/backend/nodes/gen_node_support.pl". I have a struct declared in
primnodes.h, which had some fields annotated with the pg_node_attr()
modifiers. After that, i had some in-line comments("//") as reminders for my
self, why i put the fields in the struct. The perl-script starts freaking
out if you do that, as the "read input"-loop does not know how to handle
"//"-comments after a struct-field. (Example: "Expr xpr; //Node supertype",
the script never finds the ";" semicolon at the end, because "//"-comments
are never stripped.)

I have no experience in Perl, just wanted to let you know, i encountered
this bug, maybe someone more skilled than me can fix that.

Also, if i may, the error reporting in that script is horrible. What does
"runaway <struct_name> in file "nodes/primnodes.h"." even mean?

Best regards, C



view thread (2+ messages)  latest in thread

Message-ID: <18901-424272abe01357e6@postgresql.org>
Permalink:  ../18901-424272abe01357e6@postgresql.org/
Also on:    postgresql.org/message-id/18901-424272abe01357e6@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, pgsql-bugs@lists.postgresql.org, clemens.ruck@t-online.de
  Subject: Re: BUG #18901: Bug in Perl-Script "src/backend/nodes/gen_node_support.pl"
  In-Reply-To: <18901-424272abe01357e6@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox