pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: william allen <williamedwinallen@live.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15858: could not stat file - over 4GB
Date: Thu, 17 Sep 2020 12:04:57 -0400
Message-ID: <190302.1600358697@sss.pgh.pa.us> (raw)
In-Reply-To: <CAC+AXB0wFFYep_7ZHCARVZhF2vMTpDT_X1rSz0=LAesOkBH6=g@mail.gmail.com>
References: <CAC+AXB0j9pN4z5XxMbn6+kcE_QM+CErjfYp-vVz2rU4suU7u=g@mail.gmail.com>
	<16138.1560966010@sss.pgh.pa.us>
	<17044.1560967356@sss.pgh.pa.us>
	<CAC+AXB2Fu5oJm7pmS1Pg3Gf_XyxSfun1DA7dPf+yZFQ3p5vV3g@mail.gmail.com>
	<20190626022236.GE1714@paquier.xyz>
	<CAC+AXB2VAQ+ZTxXKStyijEac6rJOa0HvSEOikfF4+Pm5Q_3dvg@mail.gmail.com>
	<19504.1566596960@sss.pgh.pa.us>
	<CAC+AXB0pPVeg4=PejrjOcYpJoTQaOrKLtEsDm6VaYeQaT-7uLA@mail.gmail.com>
	<DB6P189MB03760378FA59801300ACAF63C3660@DB6P189MB0376.EURP189.PROD.OUTLOOK.COM>
	<CAC+AXB0Jeas=nYVbbn5P0hVPDTiVYjMKLCyh9_XDNv8Db+ezyA@mail.gmail.com>
	<20200917074556.GY2873@paquier.xyz>
	<CAC+AXB0wFFYep_7ZHCARVZhF2vMTpDT_X1rSz0=LAesOkBH6=g@mail.gmail.com>

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
> Thanks for the reminder. Please find attached a rebased version.

(This hasn't shown up on -hackers yet, maybe caught in moderation?)

I took a quick look through this.  I'm not qualified to review the
actual Windows code in win32stat.c, but as far as the way you're
plugging it into the system goes, it looks good and seems to comport
with the discussion so far.

One thing I noticed, which is a pre-existing problem but maybe now
is a good time to consider it, is that we're mapping lstat() to be
exactly stat() on Windows.  That made sense years ago when (we
believed that) Windows didn't have symlinks, but surely it no longer
makes sense.

Another more trivial point is that it'd be good to run the new code
through pgindent before committing.

			regards, tom lane





view thread (45+ messages)  latest in thread

Message-ID: <190302.1600358697@sss.pgh.pa.us>
Permalink:  ../190302.1600358697@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/190302.1600358697@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, juanjo.santamaria@gmail.com, michael@paquier.xyz, williamedwinallen@live.com, pgsql-bugs@lists.postgresql.org, magnus@hagander.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: BUG #15858: could not stat file - over 4GB
  In-Reply-To: <190302.1600358697@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox