From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: cyg0810@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17088: FailedAssertion in prepagg.c
Date: Wed, 07 Jul 2021 17:56:12 -0400
Message-ID: <1911540.1625694972@sss.pgh.pa.us> (raw)
In-Reply-To: <875yxlrf5x.fsf@news-spur.riddles.org.uk>
References: <17088-e33882b387de7f5c@postgresql.org>
<YOWJQTovI//DNe8/@paquier.xyz>
<1908212.1625690962@sss.pgh.pa.us>
<87a6mxrggq.fsf@news-spur.riddles.org.uk>
<1909846.1625692937@sss.pgh.pa.us>
<875yxlrf5x.fsf@news-spur.riddles.org.uk>
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
> Tom> Hmm. Maybe it'd be better if the default behavior in
> Tom> expression_tree_walker/mutator did not include recursing into the
> Tom> args, then?
> You'd think, but as I recall (I will re-check this to confirm) there
> were more places where we _did_ need to recurse (especially during parse
> analysis before we've matched up the sortgrouprefs), while most of the
> places where recursion needed to be explicitly avoided already needed
> special-case handling, so having the default the other way would likely
> have required a special-case almost everywhere.
Fair enough. This is the kind of design choice that can be worth
revisiting later; but if the conclusion is still the same, fine with me.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk, michael@paquier.xyz, cyg0810@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17088: FailedAssertion in prepagg.c
In-Reply-To: <1911540.1625694972@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox