agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedBUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
7+ messages / 5 participants
[nested] [flat]
* BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
@ 2026-08-23 11:00 PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: PG Bug reporting form @ 2026-08-23 11:00 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: exclusion@gmail.com
The following bug has been logged on the website:
Bug reference: 19637
Logged by: Alexander Lakhin
Email address: exclusion@gmail.com
PostgreSQL version: 19beta3
Operating system: Ubuntu 24.04
Description:
The following script:
CREATE OR REPLACE FUNCTION event_trigger_report_end()
RETURNS event_trigger
LANGUAGE plpgsql
AS $$
DECLARE r RECORD;
BEGIN
FOR r IN SELECT * FROM pg_event_trigger_ddl_commands()
LOOP
RAISE NOTICE 'END: command_tag=% type=% identity=%',
r.command_tag, r.object_type, r.object_identity;
END LOOP;
END; $$;
CREATE EVENT TRIGGER regress_event_trigger_report_end ON ddl_command_end
EXECUTE PROCEDURE event_trigger_report_end();
CREATE PROPERTY GRAPH pg;
GRANT SELECT ON PROPERTY GRAPH pg TO public;
fails with:
ERROR: XX000: unsupported object type: 30
CONTEXT: PL/pgSQL function event_trigger_report_end() line 4 at FOR over
SELECT rows
LOCATION: stringify_grant_objtype, event_trigger.c:2335
Reproduced starting from 2f094e7ac.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
@ 2026-08-24 13:30 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-25 19:28 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Nathan Bossart <nathandbossart@gmail.com>
2026-08-26 00:50 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Fujii Masao <masao.fujii@gmail.com>
0 siblings, 2 replies; 7+ messages in thread
From: Andrey Rachitskiy @ 2026-08-24 13:30 UTC (permalink / raw)
To: exclusion@gmail.com; pgsql-bugs@lists.postgresql.org; +Cc: Peter Eisentraut <peter@eisentraut.org>
пн, 24 авг. 2026 г. в 17:16, PG Bug reporting form <noreply@postgresql.org>:
> The following bug has been logged on the website:
>
> Bug reference: 19637
> Logged by: Alexander Lakhin
> Email address: exclusion@gmail.com
> PostgreSQL version: 19beta3
> Operating system: Ubuntu 24.04
> Description:
>
> The following script:
> CREATE OR REPLACE FUNCTION event_trigger_report_end()
> RETURNS event_trigger
> LANGUAGE plpgsql
> AS $$
> DECLARE r RECORD;
> BEGIN
> FOR r IN SELECT * FROM pg_event_trigger_ddl_commands()
> LOOP
> RAISE NOTICE 'END: command_tag=% type=% identity=%',
> r.command_tag, r.object_type, r.object_identity;
> END LOOP;
> END; $$;
> CREATE EVENT TRIGGER regress_event_trigger_report_end ON ddl_command_end
> EXECUTE PROCEDURE event_trigger_report_end();
>
> CREATE PROPERTY GRAPH pg;
> GRANT SELECT ON PROPERTY GRAPH pg TO public;
>
> fails with:
> ERROR: XX000: unsupported object type: 30
> CONTEXT: PL/pgSQL function event_trigger_report_end() line 4 at FOR over
> SELECT rows
> LOCATION: stringify_grant_objtype, event_trigger.c:2335
>
> Reproduced starting from 2f094e7ac.
>
>
> Dear Alexander,
Thanks for the report.
This is a leftover from commit 2f094e7ac
The fix returns "PROPERTY GRAPH", matching the GRANT command spelling.
--
Regards,
Rachitskiy Andrey
Attachments:
[text/x-patch] 0001-Fix-pg_event_trigger_ddl_commands-for-GRANT-ON-PROPERTY-GRAPH.patch (4.5K, ../../CAB8bMivK0tOjR-F8foHXbk0c5woB9Ho3H5KUwm9BT76CMv2PaQ@mail.gmail.com/3-0001-Fix-pg_event_trigger_ddl_commands-for-GRANT-ON-PROPERTY-GRAPH.patch)
download | inline diff:
From: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Subject: [PATCH] Fix pg_event_trigger_ddl_commands for GRANT ON PROPERTY GRAPH
stringify_grant_objtype() treated OBJECT_PROPGRAPH as unused, so
pg_event_trigger_ddl_commands() failed with "unsupported object type"
when a ddl_command_end trigger inspected GRANT/REVOKE on a property
graph. Return "PROPERTY GRAPH" like the GRANT command syntax.
BUG: 19637
Author: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/19637-4446f72945492ed8@postgresql.org
---
diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c
index adc6eabc0f4..4edc83cdf7d 100644
--- a/src/backend/commands/event_trigger.c
+++ b/src/backend/commands/event_trigger.c
@@ -2288,6 +2288,8 @@ stringify_grant_objtype(ObjectType objtype)
return "PARAMETER";
case OBJECT_PROCEDURE:
return "PROCEDURE";
+ case OBJECT_PROPGRAPH:
+ return "PROPERTY GRAPH";
case OBJECT_ROUTINE:
return "ROUTINE";
case OBJECT_TABLESPACE:
@@ -2315,7 +2317,6 @@ stringify_grant_objtype(ObjectType objtype)
case OBJECT_OPERATOR:
case OBJECT_OPFAMILY:
case OBJECT_POLICY:
- case OBJECT_PROPGRAPH:
case OBJECT_PUBLICATION:
case OBJECT_PUBLICATION_NAMESPACE:
case OBJECT_PUBLICATION_REL:
diff --git a/src/test/regress/expected/event_trigger.out b/src/test/regress/expected/event_trigger.out
index 86ae50ce531..9b55656a83e 100644
--- a/src/test/regress/expected/event_trigger.out
+++ b/src/test/regress/expected/event_trigger.out
@@ -195,6 +195,35 @@ DROP PROPERTY GRAPH gx;
NOTICE: test_event_trigger: ddl_command_end DROP PROPERTY GRAPH
DROP TABLE tv1, tv2, te1;
NOTICE: test_event_trigger: ddl_command_end DROP TABLE
+-- GRANT/REVOKE ON PROPERTY GRAPH with pg_event_trigger_ddl_commands()
+CREATE FUNCTION event_trigger_report_grant() RETURNS event_trigger
+LANGUAGE plpgsql AS $$
+DECLARE r RECORD;
+BEGIN
+ FOR r IN SELECT * FROM pg_event_trigger_ddl_commands()
+ LOOP
+ RAISE NOTICE 'END: command_tag=% type=%',
+ r.command_tag, r.object_type;
+ END LOOP;
+END; $$;
+NOTICE: test_event_trigger: ddl_command_start CREATE FUNCTION
+NOTICE: test_event_trigger: ddl_command_end CREATE FUNCTION
+CREATE EVENT TRIGGER regress_event_trigger_report_grant ON ddl_command_end
+ WHEN TAG IN ('GRANT', 'REVOKE')
+ EXECUTE FUNCTION event_trigger_report_grant();
+CREATE PROPERTY GRAPH pg_evt_grant;
+NOTICE: test_event_trigger: ddl_command_end CREATE PROPERTY GRAPH
+GRANT SELECT ON PROPERTY GRAPH pg_evt_grant TO public;
+NOTICE: test_event_trigger: ddl_command_end GRANT
+NOTICE: END: command_tag=GRANT type=PROPERTY GRAPH
+REVOKE SELECT ON PROPERTY GRAPH pg_evt_grant FROM public;
+NOTICE: test_event_trigger: ddl_command_end REVOKE
+NOTICE: END: command_tag=REVOKE type=PROPERTY GRAPH
+DROP PROPERTY GRAPH pg_evt_grant;
+NOTICE: test_event_trigger: ddl_command_end DROP PROPERTY GRAPH
+DROP EVENT TRIGGER regress_event_trigger_report_grant;
+DROP FUNCTION event_trigger_report_grant();
+NOTICE: test_event_trigger: ddl_command_end DROP FUNCTION
-- alter owner to non-superuser should fail
alter event trigger regress_event_trigger owner to regress_evt_user;
ERROR: permission denied to change owner of event trigger "regress_event_trigger"
diff --git a/src/test/regress/sql/event_trigger.sql b/src/test/regress/sql/event_trigger.sql
index d0e6ba295fe..8959c9b6006 100644
--- a/src/test/regress/sql/event_trigger.sql
+++ b/src/test/regress/sql/event_trigger.sql
@@ -158,6 +158,27 @@ ALTER PROPERTY GRAPH gx ALTER EDGE TABLE te1 ALTER LABEL e1 DROP PROPERTIES (p1)
DROP PROPERTY GRAPH gx;
DROP TABLE tv1, tv2, te1;
+-- GRANT/REVOKE ON PROPERTY GRAPH with pg_event_trigger_ddl_commands()
+CREATE FUNCTION event_trigger_report_grant() RETURNS event_trigger
+LANGUAGE plpgsql AS $$
+DECLARE r RECORD;
+BEGIN
+ FOR r IN SELECT * FROM pg_event_trigger_ddl_commands()
+ LOOP
+ RAISE NOTICE 'END: command_tag=% type=%',
+ r.command_tag, r.object_type;
+ END LOOP;
+END; $$;
+CREATE EVENT TRIGGER regress_event_trigger_report_grant ON ddl_command_end
+ WHEN TAG IN ('GRANT', 'REVOKE')
+ EXECUTE FUNCTION event_trigger_report_grant();
+CREATE PROPERTY GRAPH pg_evt_grant;
+GRANT SELECT ON PROPERTY GRAPH pg_evt_grant TO public;
+REVOKE SELECT ON PROPERTY GRAPH pg_evt_grant FROM public;
+DROP PROPERTY GRAPH pg_evt_grant;
+DROP EVENT TRIGGER regress_event_trigger_report_grant;
+DROP FUNCTION event_trigger_report_grant();
+
-- alter owner to non-superuser should fail
alter event trigger regress_event_trigger owner to regress_evt_user;
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
@ 2026-08-25 19:28 ` Nathan Bossart <nathandbossart@gmail.com>
2026-08-25 20:01 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
1 sibling, 1 reply; 7+ messages in thread
From: Nathan Bossart @ 2026-08-25 19:28 UTC (permalink / raw)
To: Andrey Rachitskiy <pl0h0yp1@gmail.com>; +Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Does this one deserve a mention on the open items wiki [0]?
[0] https://wiki.postgresql.org/wiki/PostgreSQL_19_Open_Items
--
nathan
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-25 19:28 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Nathan Bossart <nathandbossart@gmail.com>
@ 2026-08-25 20:01 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
0 siblings, 0 replies; 7+ messages in thread
From: Andrey Rachitskiy @ 2026-08-25 20:01 UTC (permalink / raw)
To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter@eisentraut.org>
ср, 26 авг. 2026 г. в 00:28, Nathan Bossart <nathandbossart@gmail.com>:
> Does this one deserve a mention on the open items wiki [0]?
>
> [0] https://wiki.postgresql.org/wiki/PostgreSQL_19_Open_Items
>
>
> Dear Nathan,
I think we can add that.
--
Regards,
Rachitskiy Andrey
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
@ 2026-08-26 00:50 ` Fujii Masao <masao.fujii@gmail.com>
2026-08-26 03:08 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
1 sibling, 1 reply; 7+ messages in thread
From: Fujii Masao @ 2026-08-26 00:50 UTC (permalink / raw)
To: Andrey Rachitskiy <pl0h0yp1@gmail.com>; +Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On Mon, Aug 24, 2026 at 10:30 PM Andrey Rachitskiy <pl0h0yp1@gmail.com> wrote:
> This is a leftover from commit 2f094e7ac
> The fix returns "PROPERTY GRAPH", matching the GRANT command spelling.
Thanks for the patch!
The code change looks good to me.
Regarding the test, how about simplifying it by reusing the existing
event_trigger_report_end() trigger instead of adding a new event
trigger function just for this case? We could also reuse the property
graph created earlier in event_trigger.sql. This would keep the added
test smaller and fit better with the existing tests.
For example,
----------------------------------------------------------------------------
diff --git a/src/test/regress/sql/event_trigger.sql
b/src/test/regress/sql/event_trigger.sql
index d0e6ba295fe..bbdac7db984 100644
--- a/src/test/regress/sql/event_trigger.sql
+++ b/src/test/regress/sql/event_trigger.sql
@@ -155,8 +155,6 @@ CREATE PROPERTY GRAPH gx
EDGE TABLES (te1 SOURCE tv1 DESTINATION tv2 LABEL e1 PROPERTIES (q as p1));
ALTER PROPERTY GRAPH gx ALTER EDGE TABLE te1 ALTER LABEL e1 DROP
PROPERTIES (p1);
-DROP PROPERTY GRAPH gx;
-DROP TABLE tv1, tv2, te1;
-- alter owner to non-superuser should fail
alter event trigger regress_event_trigger owner to regress_evt_user;
@@ -335,6 +333,12 @@ END; $$;
CREATE EVENT TRIGGER regress_event_trigger_report_end ON ddl_command_end
EXECUTE PROCEDURE event_trigger_report_end();
+-- GRANT/REVOKE ON PROPERTY GRAPH with pg_event_trigger_ddl_commands()
+GRANT SELECT ON PROPERTY GRAPH gx TO public;
+REVOKE SELECT ON PROPERTY GRAPH gx FROM public;
+DROP PROPERTY GRAPH gx;
+DROP TABLE tv1, tv2, te1;
+
CREATE SCHEMA evttrig
CREATE TABLE one (col_a SERIAL PRIMARY KEY, col_b text DEFAULT
'forty two', col_c SERIAL)
CREATE INDEX one_idx ON one (col_b)
----------------------------------------------------------------------------
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-26 00:50 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Fujii Masao <masao.fujii@gmail.com>
@ 2026-08-26 03:08 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-27 09:59 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Rachitskiy @ 2026-08-26 03:08 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter@eisentraut.org>
ср, 26 авг. 2026 г. в 05:50, Fujii Masao <masao.fujii@gmail.com>:
> The code change looks good to me.
>
> Regarding the test, how about simplifying it by reusing the existing
> event_trigger_report_end() trigger instead of adding a new event
> trigger function just for this case? We could also reuse the property
> graph created earlier in event_trigger.sql. This would keep the added
> test smaller and fit better with the existing tests.
>
> Dear Fujii-san,
Thanks for the review.
Agreed, it's better this way.
fix in v2.
--
Regards,
Rachitskiy Andrey
Attachments:
[text/x-patch] v2-0001-Fix-pg_event_trigger_ddl_commands-for-GRANT-ON-PROPERTY-GRAPH.patch (5.3K, ../../CAB8bMis4Ub73gkGg+zm1+x0f3aPr=W9ks-aH0KC3ZSVPXV1=Bw@mail.gmail.com/3-v2-0001-Fix-pg_event_trigger_ddl_commands-for-GRANT-ON-PROPERTY-GRAPH.patch)
download | inline diff:
From 918e8a48b75c0d16e2a8976e1ca78cbca66fd5de Mon Sep 17 00:00:00 2001
From: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Date: Wed, 26 Aug 2026 07:49:58 +0500
Subject: [PATCH v2] Fix pg_event_trigger_ddl_commands for GRANT ON PROPERTY
GRAPH
stringify_grant_objtype() treated OBJECT_PROPGRAPH as unused, so
pg_event_trigger_ddl_commands() failed with "unsupported object type"
when a ddl_command_end trigger inspected GRANT/REVOKE on a property
graph. Return "PROPERTY GRAPH" like the GRANT command syntax.
BUG: 19637
Author: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/19637-4446f72945492ed8@postgresql.org
---
src/backend/commands/event_trigger.c | 3 ++-
src/test/regress/expected/event_trigger.out | 18 ++++++++++++++----
src/test/regress/sql/event_trigger.sql | 8 ++++++--
3 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c
index adc6eabc0f4..4edc83cdf7d 100644
--- a/src/backend/commands/event_trigger.c
+++ b/src/backend/commands/event_trigger.c
@@ -2288,6 +2288,8 @@ stringify_grant_objtype(ObjectType objtype)
return "PARAMETER";
case OBJECT_PROCEDURE:
return "PROCEDURE";
+ case OBJECT_PROPGRAPH:
+ return "PROPERTY GRAPH";
case OBJECT_ROUTINE:
return "ROUTINE";
case OBJECT_TABLESPACE:
@@ -2315,7 +2317,6 @@ stringify_grant_objtype(ObjectType objtype)
case OBJECT_OPERATOR:
case OBJECT_OPFAMILY:
case OBJECT_POLICY:
- case OBJECT_PROPGRAPH:
case OBJECT_PUBLICATION:
case OBJECT_PUBLICATION_NAMESPACE:
case OBJECT_PUBLICATION_REL:
diff --git a/src/test/regress/expected/event_trigger.out b/src/test/regress/expected/event_trigger.out
index 86ae50ce531..8e8310ff34d 100644
--- a/src/test/regress/expected/event_trigger.out
+++ b/src/test/regress/expected/event_trigger.out
@@ -191,10 +191,6 @@ CREATE PROPERTY GRAPH gx
NOTICE: test_event_trigger: ddl_command_end CREATE PROPERTY GRAPH
ALTER PROPERTY GRAPH gx ALTER EDGE TABLE te1 ALTER LABEL e1 DROP PROPERTIES (p1);
NOTICE: test_event_trigger: ddl_command_end ALTER PROPERTY GRAPH
-DROP PROPERTY GRAPH gx;
-NOTICE: test_event_trigger: ddl_command_end DROP PROPERTY GRAPH
-DROP TABLE tv1, tv2, te1;
-NOTICE: test_event_trigger: ddl_command_end DROP TABLE
-- alter owner to non-superuser should fail
alter event trigger regress_event_trigger owner to regress_evt_user;
ERROR: permission denied to change owner of event trigger "regress_event_trigger"
@@ -434,6 +430,20 @@ BEGIN
END; $$;
CREATE EVENT TRIGGER regress_event_trigger_report_end ON ddl_command_end
EXECUTE PROCEDURE event_trigger_report_end();
+-- GRANT/REVOKE ON PROPERTY GRAPH with pg_event_trigger_ddl_commands()
+GRANT SELECT ON PROPERTY GRAPH gx TO public;
+NOTICE: END: command_tag=GRANT type=PROPERTY GRAPH identity=<NULL>
+REVOKE SELECT ON PROPERTY GRAPH gx FROM public;
+NOTICE: END: command_tag=REVOKE type=PROPERTY GRAPH identity=<NULL>
+DROP PROPERTY GRAPH gx;
+NOTICE: NORMAL: orig=t normal=f istemp=f type=property graph identity=public.gx schema=public name=gx addr={public,gx} args={}
+NOTICE: NORMAL: orig=f normal=t istemp=f type=property graph element identity=te1 of property graph public.gx schema=<NULL> name=<NULL> addr={public,gx,te1} args={}
+DROP TABLE tv1, tv2, te1;
+NOTICE: NORMAL: orig=t normal=f istemp=f type=table identity=public.te1 schema=public name=te1 addr={public,te1} args={}
+NOTICE: NORMAL: orig=t normal=f istemp=f type=table identity=public.tv2 schema=public name=tv2 addr={public,tv2} args={}
+NOTICE: NORMAL: orig=f normal=t istemp=f type=table constraint identity=te1_b_fkey on public.te1 schema=public name=<NULL> addr={public,te1,te1_b_fkey} args={}
+NOTICE: NORMAL: orig=t normal=f istemp=f type=table identity=public.tv1 schema=public name=tv1 addr={public,tv1} args={}
+NOTICE: NORMAL: orig=f normal=t istemp=f type=table constraint identity=te1_a_fkey on public.te1 schema=public name=<NULL> addr={public,te1,te1_a_fkey} args={}
CREATE SCHEMA evttrig
CREATE TABLE one (col_a SERIAL PRIMARY KEY, col_b text DEFAULT 'forty two', col_c SERIAL)
CREATE INDEX one_idx ON one (col_b)
diff --git a/src/test/regress/sql/event_trigger.sql b/src/test/regress/sql/event_trigger.sql
index d0e6ba295fe..bbdac7db984 100644
--- a/src/test/regress/sql/event_trigger.sql
+++ b/src/test/regress/sql/event_trigger.sql
@@ -155,8 +155,6 @@ CREATE PROPERTY GRAPH gx
EDGE TABLES (te1 SOURCE tv1 DESTINATION tv2 LABEL e1 PROPERTIES (q as p1));
ALTER PROPERTY GRAPH gx ALTER EDGE TABLE te1 ALTER LABEL e1 DROP PROPERTIES (p1);
-DROP PROPERTY GRAPH gx;
-DROP TABLE tv1, tv2, te1;
-- alter owner to non-superuser should fail
alter event trigger regress_event_trigger owner to regress_evt_user;
@@ -335,6 +333,12 @@ END; $$;
CREATE EVENT TRIGGER regress_event_trigger_report_end ON ddl_command_end
EXECUTE PROCEDURE event_trigger_report_end();
+-- GRANT/REVOKE ON PROPERTY GRAPH with pg_event_trigger_ddl_commands()
+GRANT SELECT ON PROPERTY GRAPH gx TO public;
+REVOKE SELECT ON PROPERTY GRAPH gx FROM public;
+DROP PROPERTY GRAPH gx;
+DROP TABLE tv1, tv2, te1;
+
CREATE SCHEMA evttrig
CREATE TABLE one (col_a SERIAL PRIMARY KEY, col_b text DEFAULT 'forty two', col_c SERIAL)
CREATE INDEX one_idx ON one (col_b)
--
2.53.0
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-26 00:50 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Fujii Masao <masao.fujii@gmail.com>
2026-08-26 03:08 ` Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH Andrey Rachitskiy <pl0h0yp1@gmail.com>
@ 2026-08-27 09:59 ` Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2026-08-27 09:59 UTC (permalink / raw)
To: Andrey Rachitskiy <pl0h0yp1@gmail.com>; Fujii Masao <masao.fujii@gmail.com>; +Cc: exclusion@gmail.com; pgsql-bugs@lists.postgresql.org
On 26.08.26 05:08, Andrey Rachitskiy wrote:
> ср, 26 авг. 2026 г. в 05:50, Fujii Masao <masao.fujii@gmail.com
> <mailto:masao.fujii@gmail.com>>:
>
> The code change looks good to me.
>
> Regarding the test, how about simplifying it by reusing the existing
> event_trigger_report_end() trigger instead of adding a new event
> trigger function just for this case? We could also reuse the property
> graph created earlier in event_trigger.sql. This would keep the added
> test smaller and fit better with the existing tests.
>
> Dear Fujii-san,
>
> Thanks for the review.
> Agreed, it's better this way.
> fix in v2.
committed
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-08-27 09:59 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-23 11:00 BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH PG Bug reporting form <noreply@postgresql.org>
2026-08-24 13:30 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-25 19:28 ` Nathan Bossart <nathandbossart@gmail.com>
2026-08-25 20:01 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-26 00:50 ` Fujii Masao <masao.fujii@gmail.com>
2026-08-26 03:08 ` Andrey Rachitskiy <pl0h0yp1@gmail.com>
2026-08-27 09:59 ` Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox