From: Peter Eisentraut <peter@eisentraut.org>
To: Andrey Rachitskiy <pl0h0yp1@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
Date: Thu, 27 Aug 2026 11:59:18 +0200
Message-ID: <6823e088-fee5-4f6b-8f4a-478c8b4a3a67@eisentraut.org> (raw)
In-Reply-To: <CAB8bMis4Ub73gkGg+zm1+x0f3aPr=W9ks-aH0KC3ZSVPXV1=Bw@mail.gmail.com>
References: <19637-4446f72945492ed8@postgresql.org>
<CAB8bMivK0tOjR-F8foHXbk0c5woB9Ho3H5KUwm9BT76CMv2PaQ@mail.gmail.com>
<CAHGQGwH_uiUXf5X8s0Prrn+z-YtSz6tF7GE2QogH=UK0tyEyNw@mail.gmail.com>
<CAB8bMis4Ub73gkGg+zm1+x0f3aPr=W9ks-aH0KC3ZSVPXV1=Bw@mail.gmail.com>
On 26.08.26 05:08, Andrey Rachitskiy wrote:
> ср, 26 авг. 2026 г. в 05:50, Fujii Masao <masao.fujii@gmail.com
> <mailto:masao.fujii@gmail.com>>:
>
> The code change looks good to me.
>
> Regarding the test, how about simplifying it by reusing the existing
> event_trigger_report_end() trigger instead of adding a new event
> trigger function just for this case? We could also reuse the property
> graph created earlier in event_trigger.sql. This would keep the added
> test smaller and fit better with the existing tests.
>
> Dear Fujii-san,
>
> Thanks for the review.
> Agreed, it's better this way.
> fix in v2.
committed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter@eisentraut.org, pl0h0yp1@gmail.com, masao.fujii@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH
In-Reply-To: <6823e088-fee5-4f6b-8f4a-478c8b4a3a67@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox