From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mats Kindahl <mats@timescale.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: daniel@yesql.se
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Crash during backend start when low on memory
Date: Mon, 16 Jan 2023 15:58:43 -0500
Message-ID: <1987527.1673902723@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+14426M6j-YrkNLu9Hsjerbh3nXaz1gQ-Di+L+EaDoZtkdMVg@mail.gmail.com>
References: <20230113115352.sbuv5egpjyoxn52i@alvherre.pgsql>
<1676515.1673622084@sss.pgh.pa.us>
<CA+14426M6j-YrkNLu9Hsjerbh3nXaz1gQ-Di+L+EaDoZtkdMVg@mail.gmail.com>
Mats Kindahl <mats@timescale.com> writes:
> On Fri, Jan 13, 2023 at 4:01 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, the BackendStartup change is 100% wrong; it is replacing
>> perfectly good code that recovers correctly with bad code that
>> will take down the postmaster (not a backend child!) on OOM.
> AFAICT, the error is caught by the caller (using PG_TRY), executes some
> cleanup code, and then continues executing, so it shouldn't take down the
> postmaster.
There are no PG_TRY blocks in the postmaster, and certainly no recovery.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, mats@timescale.com, alvherre@alvh.no-ip.org, daniel@yesql.se, pgsql-bugs@lists.postgresql.org
Subject: Re: Crash during backend start when low on memory
In-Reply-To: <1987527.1673902723@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox