From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Alexander Law <exclusion@gmail.com>
Subject: Re: BUG #17302: gist index prevents insertion of some data
Date: Wed, 01 Dec 2021 17:14:03 -0500
Message-ID: <1999382.1638396843@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdv4YHbQvo2VhAdCv7SAQtEP29CbRPJyF8z9a92ZQ=kFpA@mail.gmail.com>
References: <17302-dea8025c932a92f1@postgresql.org>
<CAPpHfdv4YHbQvo2VhAdCv7SAQtEP29CbRPJyF8z9a92ZQ=kFpA@mail.gmail.com>
Alexander Korotkov <aekorotkov@gmail.com> writes:
> I think losing precision in the gist penalty is generally OK. Thus,
> it shouldn't be a problem to round a very small value as zero.
Check.
> Probably, we could even tolerate overflow in the gist penalty.
As long as overflow -> infinity, yeah I think so. Seems like it
was a mistake to insert the overflow-testing functions in this code
at all, and we should simplify it down to plain C addition/subtraction/
multiplication.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, pgsql-hackers@lists.postgresql.org, exclusion@gmail.com
Subject: Re: BUG #17302: gist index prevents insertion of some data
In-Reply-To: <1999382.1638396843@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox