From: Bossart, Nathan <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly
Date: Wed, 22 May 2019 16:59:53 +0000
Message-ID: <1FE3AB7F-0AF9-4F38-B41D-51F219509281@amazon.com> (raw)
In-Reply-To: <20190522062626.GC1486@paquier.xyz>
References: <15788-4e18847520ebcc75@postgresql.org>
<9C9271CF-9A7A-45AE-B034-1246A93788C9@amazon.com>
<CAJrrPGcsS_=bTuKvPOg6TEgkrc9PaEJVCFmhm=z_7VKpLnjxOg@mail.gmail.com>
<4D066CB2-B177-40B4-8510-9318B9A184CE@amazon.com>
<20190504123221.GA2127@paquier.xyz>
<0AF6E4BC-EE9A-4158-85BE-3EAE4308D228@amazon.com>
<20190520082705.GA1921@paquier.xyz>
<92E61F31-BD06-49B1-950F-8863239E342F@amazon.com>
<20190522062626.GC1486@paquier.xyz>
On 5/21/19, 11:26 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> On Mon, May 20, 2019 at 10:37:50PM +0000, Bossart, Nathan wrote:
>> On 5/20/19, 1:27 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
>>> I had first a hard time parsing the subqueries added, so I have
>>> tweaked your patch with more indentation, and a comment block with
>>> more details about why we need to preserve the ACL ordering (you will
>>> note that I don't have a lot of imagination here).
>>
>> Thanks. Your version looks good to me.
>
> Okay, I have done more tests, checks and tweaks on this stuff, and
> pushed the fix for databases down to 9.6.
Thanks!
> The problem comes from dumpTablespaces() which still has a broken ACL
> ordering logic. I'll start a new thread about that as this thread is
> actually now fixed. It would be interesting to refactor all that
> stuff, but I'd like to think that it would be much more interesting if
> we could get pg_init_privs to work with databases and tablespace
> instead, but that would not be back-patchable. So I'll focus on the
> bug fix.
I'll take a look at this.
Nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bossartn@amazon.com, michael@paquier.xyz, kommi.haribabu@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly
In-Reply-To: <1FE3AB7F-0AF9-4F38-B41D-51F219509281@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox