From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: kmanh999@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17439: DROP FUNCTION functionName(); drops associated generated column without using CASCADE
Date: Wed, 16 Mar 2022 20:05:48 +0100
Message-ID: <1a0a5a4c-5ab0-3e84-9d1b-9e0ed650b729@enterprisedb.com> (raw)
In-Reply-To: <412466.1647374777@sss.pgh.pa.us>
References: <17439-7df4421197e928f0@postgresql.org>
<339142.1647369200@sss.pgh.pa.us>
<412466.1647374777@sss.pgh.pa.us>
On 15.03.22 21:06, Tom Lane wrote:
> I looked into SQL:2021, and AFAICS the existing behavior is flat wrong,
> even for cross references to other table columns. I think you read
> 11.23 <drop column definition> general rule 3, which seems to say to
> unconditionally drop any generated column depending on the target column
> ... but you missed syntax rule 7f, which says
>
> 7) If RESTRICT is specified, then C shall not be referenced in any of the
> following:
> ...
> f) The generation expression of any column descriptor.
>
> GR3 would be very strange if read in isolation anyway, because it
> says to drop the generated column with CASCADE, which could cause
> arbitrary stuff to go away. That is sensible if you know that 7f
> prevents us from getting here unless the original drop said CASCADE,
> but otherwise it's a pretty astonishing thing.
The reported case is a DROP FUNCTION, but looking at <drop routine
statement>, it doesn't say anything about what to do with generation
expressions. That might be a bug in the standard, too.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, kmanh999@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17439: DROP FUNCTION functionName(); drops associated generated column without using CASCADE
In-Reply-To: <1a0a5a4c-5ab0-3e84-9d1b-9e0ed650b729@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox