pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>
Cc: Gunnar Morling <gunnar.morling@googlemail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Date: Wed, 09 Jul 2025 09:12:51 +0200
Message-ID: <1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at> (raw)
In-Reply-To: <CAA4eK1JaYNQtTj5u-YP3G2UJbJoevD4PnUiM+sQy8DerjNPJFA@mail.gmail.com>
References: <CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
	<CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
	<30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
	<b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
	<686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
	<e0789f10-5b48-4d6b-a32c-0f4426d254df@oss.nttdata.com>
	<CAA4eK1LOyUeCHk3hMtjT-bpqXLAnjODwcO+o7+bTnB2es-fSqw@mail.gmail.com>
	<70b183fb-f66e-40d8-b0de-be8c1052fa93@oss.nttdata.com>
	<CAKFQuwYVEgy+fiHMvSoykiEef-VF-ZV9Gxv4rynk9NNK9UMPYQ@mail.gmail.com>
	<472687.1751731008@sss.pgh.pa.us>
	<474268.1751731988@sss.pgh.pa.us>
	<f12271e6aea3b87eaa430d0c9008ca1f3154c31e.camel@cybertec.at>
	<CAA4eK1JaYNQtTj5u-YP3G2UJbJoevD4PnUiM+sQy8DerjNPJFA@mail.gmail.com>

On Wed, 2025-07-09 at 12:05 +0530, Amit Kapila wrote:
> On Tue, Jul 8, 2025 at 10:23 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> > 
> > On Sat, 2025-07-05 at 12:13 -0400, Tom Lane wrote:
> > > Oh, wait a second.  I just noticed that this variable is new in v18.
> > > So there won't be a compatibility issue as long as we change it in
> > > v18 too.  So changing it to a base of seconds seems sufficient,
> > > and more in line with existing practice:
> > > 
> > > Using 'ms' seems clearly overkill, but there's precedent for
> > > timeouts measured in seconds.
> > 
> > Here is a patch that changes the unit to seconds, like Fujii Masao's
> > patch upthread.  In addition, it removes the now unnecessary injection
> > point for the TAP test and tries to improve the documentation to
> > address my complaints.
> > 
> 
> +# Wait a bit for the replication slots to become invalid
> +$node->safe_psql('postgres', "SELECT pg_sleep(2)");
> 
> Is it a good idea to add 2s to 'make check-world' for one particular test?

That is debatable.  I thought that adding two seconds would be worth the
advantage of removing the injection point that only fakes the timeout.
We'd get better test coverage.

But if the people who run the regression tests dozens of times every day
object to the two seconds, I won't insist on this part of the patch.

Yours,
Laurenz Albe





view thread (38+ messages)  latest in thread

Message-ID: <1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at>
Permalink:  ../1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at/
Also on:    postgresql.org/message-id/1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: laurenz.albe@cybertec.at, amit.kapila16@gmail.com, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, masao.fujii@oss.nttdata.com, nisha.moond412@gmail.com, gunnar.morling@googlemail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
  In-Reply-To: <1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox