From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@2ndquadrant.com>
Cc: PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: Fri, 20 Jun 2014 14:11:04 -0400
Message-ID: <20140620181104.GF29143@momjian.us> (raw)
In-Reply-To: <8519.1403286102@sss.pgh.pa.us>
References: <20140619020633.GA20469@momjian.us>
<20140619015205.GD3806@momjian.us>
<20140619014034.GC3806@momjian.us>
<20140619220425.GQ18688@eldon.alvh.no-ip.org>
<20140619221240.GC27747@eldon.alvh.no-ip.org>
<20140620171915.GC29143@momjian.us>
<20140620173351.GV18688@eldon.alvh.no-ip.org>
<8519.1403286102@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
On Fri, Jun 20, 2014 at 01:41:42PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Bruce Momjian wrote:
> >> Why would we want this if the system functions fine without those files
> >> being created? I don't think we want pg_resetxlog to be doing anything
> >> except changing pg_controldata.
>
> > I don't understand why you say the system functions fine. If you move
> > the multixactid with pg_resetxlog to a point which doesn't have the
> > necessary file and page, the system will not start. Only pg_upgrade
> > knows to create the file appropriately, but normal operation doesn't.
>
> Yeah. In my mind, at least, there's been a TODO for some time for
> pg_resetxlog to make sure that pg_clog and the other SLRU-like files
> get populated appropriately when you tell it to change those counters.
> You have to have a segment file at the right place or startup fails.
>
> I'm not sure why Alvaro chose to fix this only for pg_multixact, but
> fixing that case is better than not fixing anything.
Well, if we are going to do this, we had better do all cases or the
behavior will be quite surprising, and when doing disaster recovery,
surprises are not good. I am a little worried that removing files as
part of pg_resetxlog might cause data to be lost as users try to figure
things out.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, andres@2ndquadrant.com
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
In-Reply-To: <20140620181104.GF29143@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox