From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: David E. Wheeler <david@justatheory.com>
Cc: Christophe Pettus <christophe.pettus@pgexperts.com>
Cc: pgsql-bugs@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: [BUGS] BUG #14825: enum type: unsafe use?
Date: Tue, 26 Sep 2017 17:45:48 -0400
Message-ID: <20170926214548.GQ4628@tamriel.snowman.net> (raw)
In-Reply-To: <16025.1506461535@sss.pgh.pa.us>
References: <27064.1506350579@sss.pgh.pa.us>
<5f4f29bf-90b1-e49a-6cf9-069c59bc1067@2ndQuadrant.com>
<40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com>
<1090.1506365074@sss.pgh.pa.us>
<9666.1506446327@sss.pgh.pa.us>
<329.1506451066@sss.pgh.pa.us>
<38835cdd-!c378-8d7a-013b-fd733c78c649@2ndQuadrant.com>
<12792.1506456422@sss.pgh.pa.us>
<20170926211419.GB7167@momjian.us>
<16025.1506461535@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom, all,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Sep 26, 2017 at 04:07:02PM -0400, Tom Lane wrote:
> >> Any other votes out there?
>
> > Well, I was concerned yesterday that we had a broken build farm so close
> > to release. (I got consistent regression failures.) I think PG 11 would
> > be better for this feature change, so I support reverting this.
>
> I'll take the blame for (most of) yesterday's failures in the v10
> branch, but they were unrelated to this patch --- they were because
> of that SIGBUS patch I messed up. So that doesn't seem like a very
> applicable argument. Still, it's true that this seems like the most
> consequential patch that's gone into v10 post-RC1, certainly so if
> you discount stuff that was back-patched further than v10.
I've not been following along very closely- are we sure that ripping
this out won't be worse than dealing with it in-place? Will pulling it
out also require a post-RC1 catversion bump?
If we can pull it out without bumping catversion and with confidence
that it won't cause more problems then, as much as I hate it, I'm
inclined to say we pull it out and come back to it in v11. I really
don't like the idea of a post-rc1 catversion bump and it doesn't seem
like there's a good solution here that doesn't involve more changes and
most likely a catversion bump. If it was reasonably fixable with only
small/local changes and without a catversion bump then I'd be more
inclined to keep it, but I gather from the discussion that's not the
case.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, bruce@momjian.us, andrew.dunstan@2ndquadrant.com, david@justatheory.com, christophe.pettus@pgexperts.com, pgsql-hackers@postgresql.org
Subject: Re: [BUGS] BUG #14825: enum type: unsafe use?
In-Reply-To: <20170926214548.GQ4628@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox