From: Michael Paquier <michael.paquier@gmail.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: sk@zsrv.org
Cc: david@nlpgo.com
Cc: pgsql-bugs@lists.postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.
Date: Thu, 18 Jan 2018 17:25:05 +0900
Message-ID: <20180118082505.GA84508@paquier.xyz> (raw)
In-Reply-To: <62C2B9A0-51BC-40FF-9BCA-F203784CB9C1@yandex-team.ru>
References: <1516210494.1798.16.camel@nlpgo.com>
<412861516217175@web38o.yandex.ru>
<20180118.144851.24081723.horiguchi.kyotaro@lab.ntt.co.jp>
<62C2B9A0-51BC-40FF-9BCA-F203784CB9C1@yandex-team.ru>
On Thu, Jan 18, 2018 at 12:57:38PM +0500, Andrey Borodin wrote:
>> 18 янв. 2018 г., в 10:48, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> написал(а):
>>
>> Gist imposes the ninth strategy to perform index only scan but
>> planner is not considering that
>> ....
>> Please find the attached patch.
> I agree with you that current behavior is a bug and your patch seems correct.
> I'm a bit worried about ninth strategy words: fetch is not necessary
>> now, if opclass lacks compress methods - index only scan is
>> possible. See
>> https://github.com/postgres/postgres/commit/d3a4f89d8a3e500bd7c0b7a8a8a5ce1b47859128
>> for details.
>
> Though there are tests in cube and seg for that, if your patch passes
> check-world, than this behavior is not affected.
The proposed patch has no regression tests. If the current set is not
enough to stress the problem, you surely should add some (haven't
checked the patch in detail, sorry ;p ).
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael.paquier@gmail.com, x4mmm@yandex-team.ru, horiguchi.kyotaro@lab.ntt.co.jp, sk@zsrv.org, david@nlpgo.com, pgsql-bugs@lists.postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.
In-Reply-To: <20180118082505.GA84508@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox