From: Michael Paquier <michael@paquier.xyz>
To: TipTop Labs <office@tiptop-labs.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control
Date: Thu, 5 Apr 2018 15:58:40 +0900
Message-ID: <20180405065840.GH1732@paquier.xyz> (raw)
In-Reply-To: <E1979209-A39E-4229-BBE0-59BC43FB4691@tiptop-labs.com>
References: <CA+q6zcVCfeYoAmPyW5R+uxZ0MD6=ZunsW=uP0AS=B=RxB8M7Tg@mail.gmail.com>
<20180307014624.GC1744@paquier.xyz>
<CA+q6zcWix34kmuB6PTgizy4-7Eq2Rn4FX3tpwnH5SdgEU7ugPw@mail.gmail.com>
<30255.1522711675@sss.pgh.pa.us>
<20180403024110.GB1621@paquier.xyz>
<A89569FD-1CCB-4060-932B-B61DD0F756BF@tiptop-labs.com>
<20180404072625.GB2208@paquier.xyz>
<22961.1522867812@sss.pgh.pa.us>
<20180405013818.GC1732@paquier.xyz>
<E1979209-A39E-4229-BBE0-59BC43FB4691@tiptop-labs.com>
On Thu, Apr 05, 2018 at 07:04:40AM +0200, TipTop Labs wrote:
> One final word about my original patch, since the commit message for
> 0001 refers to its limitations: I acknowledge that it cannot cover
> situations where the order of processing files is such that the second
> loop detects non-writable files only after it had already done work on
> some others. It was meant to fix the specific problem I ran into
> without breaking the regression tests that ship with the source code
> ("make check"). The main reason that it is not more elaborate is that
> I did not want to submit anything affecting more than a few lines of
> code without prior input from the community.
That definitely makes sense to me. Reviews and discussions can take a
long time to settle so this method looks right to me. It is better not
spend too much time on a patch if you unsure of its shape, and much
better to ask for input first before diving more into the details. This
stuff is really complicated and the devil is in the details.
> So from my perspective I welcome both 0001 and 0002.
OK, thanks for confirming!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180405065840.GH1732@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, office@tiptop-labs.com, tgl@sss.pgh.pa.us, 9erthalion6@gmail.com, sawada.mshk@gmail.com, michael.paquier@gmail.com
Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control
In-Reply-To: <20180405065840.GH1732@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox