From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: bianpan2016@163.com, pgsql-bugs@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
Subject: Re: BUG #15105: OpenTransientFile() should be paired with CloseTransientFile() rather than close()
Date: Wed, 11 Apr 2018 12:30:24 +0900
Message-ID: <20180411032917.GK26769@paquier.xyz> (raw)
In-Reply-To: <12895.1523400043@sss.pgh.pa.us>
References: <152056616579.4966.583293218357089052@wrigleys.postgresql.org>
<20180309044052.GC1416@paquier.xyz>
<19686.1520607468@sss.pgh.pa.us>
<12895.1523400043@sss.pgh.pa.us>
On Tue, Apr 10, 2018 at 06:40:43PM -0400, Tom Lane wrote:
> On closer inspection, such a cross-check wouldn't have helped find this
> particular mistake, because it was in an error exit path that's likely
> never been exercised by anybody, and certainly isn't hit in the regression
> tests. Still, I think it'd be a good thing to add, and hence propose the
> attached patch. (I've verified that the warning doesn't fire in "make
> check-world".)
Good idea. +1 for your proposed patch.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180411032917.GK26769@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: BUG #15105: OpenTransientFile() should be paired with CloseTransientFile() rather than close()
In-Reply-To: <20180411032917.GK26769@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox