pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Mahadevan Ramachandran <mahadevan@rapidloop.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15245: pg_stat_all_tables does not include partition master tables
Date: Mon, 18 Jun 2018 11:06:42 +0900
Message-ID: <20180618020642.GC3721@paquier.xyz> (raw)
In-Reply-To: <CAKFQuwaV0Zz5_e7CmJoP_ULRsZ-G2y6fmMF-4QZP6eGso3J7Dg@mail.gmail.com>
References: <152922564661.24801.3078728743990100425@wrigleys.postgresql.org>
	<20180617120653.GD1411@paquier.xyz>
	<CADjCDK9APQLYPt4F2TH5xSEEYjFCe7nLphEe7L7EHV7-WuAB_A@mail.gmail.com>
	<CAKFQuwaV0Zz5_e7CmJoP_ULRsZ-G2y6fmMF-4QZP6eGso3J7Dg@mail.gmail.com>

On Sun, Jun 17, 2018 at 08:29:33AM -0700, David G. Johnston wrote:
> My first reaction was to agree, which suggests a need for a note in the
> docs why this isn't the case.  The _all_ specifically means both user and
> system; the _stats_ in the name means that only tables that have statistics
> are included.  I feel this is a reasonable decision.

If there were anything to happen here, then I think that it would be
hard to define what the statistics of the parent partition should
reflect.  For example, the autovacuum and autoanalyze run times are I
think tricky as you cannot really define the last time autovacuum has
been run on the parent as the last time it has been run only only one of
the partitions or a sub-set of them.  This gets also messier if you come
across multiple partition layers.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (16+ messages)  latest in thread

Message-ID: <20180618020642.GC3721@paquier.xyz>
Permalink:  ../20180618020642.GC3721@paquier.xyz/
Also on:    postgresql.org/message-id/20180618020642.GC3721@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, david.g.johnston@gmail.com, mahadevan@rapidloop.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15245: pg_stat_all_tables does not include partition master tables
  In-Reply-To: <20180618020642.GC3721@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox