pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Schneider, Jeremy <schnjere@amazon.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Albin, Lloyd P <lalbin@scharp.org>
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Date: Fri, 27 Jul 2018 05:41:27 +0900
Message-ID: <20180726204127.GA1754@paquier.xyz> (raw)
In-Reply-To: <E5CF1BFB-322D-41AE-ACFC-237730A9E110@amazon.com>
References: <152512087100.19803.12733865831237526317@wrigleys.postgresql.org>
	<9145334b-9583-124c-012e-7d58039ad417@amazon.com>
	<CA+TgmobgJ9b0LpwhcCdj_gMDgp9UKmR_1pfX6WpWxGGGVrOG7A@mail.gmail.com>
	<20180724041403.GF4035@paquier.xyz>
	<F4D1FB53-AAFB-4605-9336-F37A762A7738@anarazel.de>
	<20180724045010.GA4736@paquier.xyz>
	<B8A865D7-DDD0-4E04-9077-02C76B206FF5@anarazel.de>
	<20180726052415.GC3927@paquier.xyz>
	<E5CF1BFB-322D-41AE-ACFC-237730A9E110@amazon.com>

On Thu, Jul 26, 2018 at 03:06:59PM +0000, Bossart, Nathan wrote:
> I took a look at 0001.

Thanks for the lookup.  0003 is the most simple in the set by the way.

> On 7/26/18, 12:24 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
> -	myrelid = RelationGetRelid(rel);
> +	myrelid = RangeVarGetRelidExtended(rv, AccessExclusiveLock,
> +	    false, RangeVarCallbackForTruncate, NULL);
> 
> Should the flags argument be 0 instead of false?

Yes, those should be 0.  All patches are missing that.  It does not have
a bad consequence on the patch, still that's incorrect.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20180726204127.GA1754@paquier.xyz/2-signature.asc)
  download

view thread (36+ messages)  latest in thread

Message-ID: <20180726204127.GA1754@paquier.xyz>
Permalink:  ../20180726204127.GA1754@paquier.xyz/
Also on:    postgresql.org/message-id/20180726204127.GA1754@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, bossartn@amazon.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, robertmhaas@gmail.com, schnjere@amazon.com, pgsql-hackers@postgresql.org, lalbin@scharp.org
  Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
  In-Reply-To: <20180726204127.GA1754@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox