From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: abelisto@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Date: Mon, 20 Aug 2018 22:19:49 -0300
Message-ID: <20180821011949.r5ogh32qluf56na6@alvherre.pgsql> (raw)
In-Reply-To: <CAKJS1f_RzF8s5Osi2ae3fMMnBOv=zZSw51OJ1iPur=07d0Sw-w@mail.gmail.com>
On 2018-Aug-21, David Rowley wrote:
> > To reproduce:
> > $ createdb foo
> > $ psql foo -c "create table bar(i int generated by default as identity
> > primary key);"
> > $ pg_dump foo --exclude-table=bar
> > Segmentation fault (core dumped)
> I think the fix depends exactly on what we want the behaviour to be
> here. Should dumpSequence() still dump out a CREATE SEQUENCE
> statement for this, or should we just ignore the sequence? I imagine
> we should just ignore identity sequences when we're not going to dump
> the table that owns them. It looks like that would require a small
> modification in getOwnedSeqs().
Yeah, we should omit the sequence too. I don't see any principled
reason to think that the sequence is interesting on its own.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, david.rowley@2ndquadrant.com, abelisto@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
In-Reply-To: <20180821011949.r5ogh32qluf56na6@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox