From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: digoal@126.com, pgsql-bugs@lists.postgresql.org, PG Bug reporting form <noreply@postgresql.org>
Subject: Re: BUG #15565: truncate bug with tables which have temp table inherited
Date: Tue, 25 Dec 2018 17:03:14 +0900
Message-ID: <20181225080314.GF2334@paquier.xyz> (raw)
In-Reply-To: <CAKJS1f_pDqUvyWeiUufRUJ2nUHvD4-rYvjHr2ZiPLsvQ6UQkUg@mail.gmail.com>
References: <15565-ce67a48d0244436a@postgresql.org>
<0285c6d1-2d11-2f2c-6fae-d4575cdc3c7b@lab.ntt.co.jp>
<CAKJS1f_pDqUvyWeiUufRUJ2nUHvD4-rYvjHr2ZiPLsvQ6UQkUg@mail.gmail.com>
On Tue, Dec 25, 2018 at 08:27:19PM +1300, David Rowley wrote:
> I glanced at this and was confused at where "newrelation" comes from
> and also the single parameter heap_close(). It does not look like it
> would compile.
Nope, it doesn't. heap_close ought to not normally release the lock
either until the transaction has committed. The patch clobbers
something that truncate_check_activity() already checks, which is not
elegant. I am wondering as well if we could take this occasion for
having better isolation testing when it comes to inheritance trees
mixing relation persistency. At least for the TRUNCATE case it would
be nice to have something.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, david.rowley@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, noreply@postgresql.org
Subject: Re: BUG #15565: truncate bug with tables which have temp table inherited
In-Reply-To: <20181225080314.GF2334@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox