From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Hugh Ranalli <hugh@whtc.ca>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Thu, 3 Jan 2019 15:19:58 -0300
Message-ID: <201901031819.hi4hjki2pzr5@alvherre.pgsql> (raw)
In-Reply-To: <CAAhbUMPg7szHquY_3czBgNkSs1sCoGEmgwZ8OSQ7hSDDBUXRaw@mail.gmail.com>
On 2019-Jan-03, Hugh Ranalli wrote:
> I realise this is an incredibly minor component of the PostgreSQL
> infrastructure, but as I don't want to hold up reviewers, may I ask:
>
> - It seems we have two votes for Python 3 only, and one for Python 2/3.
> I lean toward Python 2/3 myself because: a) many distributions still ship
> with Python 2 as the default and b) it's a single code block that can
> easily be removed. If the decision is for Python 3, I'd like at least to
> add a check that catches this and prints a message, rather than leaving
> someone with a cryptic runtime error that makes them think the script is
> broken;
I kinda agree with Peter that this is a fringe, rarely run program where
the python3 requirement is unlikely to be onerous, but since the 2/3
compatibility is so little code, I would opt for keeping it for the time
being. We can remove it in a couple of years.
> - Michael Paquier, do you have any other comments? If not, I'll adjust
> the documentation to use the URLs you have indicated. If you are
> downloading via curl or wget, the URL I used is the proper one. It gives
> you the XML file, whereas the other saves the HTML interface, leading to
> errors if you try to run it. I'll also add this to the documentation.
I think the point is that if the committee updates with a further
version of the file, how do you find the new version? We need a URL
that's one step removed from the final file, so that we can see if we
need to update it. Maybe we can provide both URLs for convenience.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, hugh@whtc.ca, michael@paquier.xyz, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, daniel@manitou-mail.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
In-Reply-To: <201901031819.hi4hjki2pzr5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox