From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
Date: Fri, 18 Jan 2019 15:08:33 -0300
Message-ID: <201901181808.5srgir3zfzhc@alvherre.pgsql> (raw)
In-Reply-To: <201901172223.lm3iihkw7hn4@alvherre.pgsql>
On 2019-Jan-17, Alvaro Herrera wrote:
> Well, the whole point of my proposal is that the FK-creating code
> recurses to partitions by calling ATAddForeignKeyConstraint, and IMO
> that's the wrong level to recurse at; we should instead recurse by
> calling clone_fk_constraints() as a whole. That's not readibly possible
> with the current code arrangement because of layering, but after
> backpatching (as attached) the two patches I mentioned, I end up with
> the following, which I think is much cleaner. (Also, this code layout
> plays much better with my project to continue to extend FKs so that they
> are allowed to point to partitioned tables; see the other thread).
>
> The attached patches are for pg11; they don't apply to master. The
> changes are uninteresting.
Pushed this.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, jesper.pedersen@redhat.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
In-Reply-To: <201901181808.5srgir3zfzhc@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox