From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: John Klann <jk7255@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
Date: Fri, 22 Feb 2019 14:28:46 -0800
Message-ID: <20190222222846.fgxnu754kuvcwxia@alap3.anarazel.de> (raw)
In-Reply-To: <CA+hUKGKSse+dCkLzDheBt62+PUQxTc84M7BU7LoPs5DP-KrEmw@mail.gmail.com>
References: <15636-d380890dafd78fc6@postgresql.org>
<20190218162638.GH6197@tamriel.snowman.net>
<CAHyX5+VGCkWb_81_v_JsqJKzOEbBqDzjX8JmNWA5ogJTXmXgWw@mail.gmail.com>
<CA+hUKGKSse+dCkLzDheBt62+PUQxTc84M7BU7LoPs5DP-KrEmw@mail.gmail.com>
Hi,
On 2019-02-23 11:20:02 +1300, Thomas Munro wrote:
> So, for this patch tolerating EINVAL for fsync of directories (but not
> files), enabling eg pg_backbackup on CIFS on eg Linux 3.10 to work,
> tested by John, we have:
>
> Stephen: +1
> Michael: -0.1
> Thomas: -0.1
>
> Any other opinions?
>
> Just in case you think it's strange that I'm voting against my own
> patch: I'd probably be for it if I hadn't discovered that they've
> fixed this in Linux 3.16 and later so that it succeeds. It's
> apparently not in the default RHEL 6 and 7 kernels, though, and the
> latter could be around for a while. I'm not entirely sure what amount
> of work we should be doing to tolerate problems that are fixed in a
> newer versions. One argument is that a 3.10 user who cares about this
> should petition RH to back-port the fix into that kernel. (The nearby
> WSL thread has some things in common but is a more clear cut case IMV
> because there is no fix available on the WSL side.)
Hm, given the fact that EINVAL doesn't appear to be triggerable by data
level issues, I don't see much reason not to allow it. I mean it's
really stupid that cifs ever returns it, but there's going to be a lot
of users running things on older kernel for the forseeable future.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: andres@anarazel.de, thomas.munro@gmail.com, jk7255@gmail.com, sfrost@snowman.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
In-Reply-To: <20190222222846.fgxnu754kuvcwxia@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox