pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost <sfrost@snowman.net>
Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords
Date: Tue, 23 Apr 2019 11:10:18 +0900
Message-ID: <20190423021018.GF2712@paquier.xyz> (raw)
In-Reply-To: <265876b8-1a72-89cd-bdcf-e641d93e166c@postgresql.org>
References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org>
	<4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org>
	<20190422015051.GA3433@paquier.xyz>
	<3033.1555940554@sss.pgh.pa.us>
	<5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org>
	<30284.1555972921@sss.pgh.pa.us>
	<15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org>
	<20190423010142.GE2712@paquier.xyz>
	<10698.1555981849@sss.pgh.pa.us>
	<265876b8-1a72-89cd-bdcf-e641d93e166c@postgresql.org>

On Mon, Apr 22, 2019 at 09:16:49PM -0400, Jonathan S. Katz wrote:
> +1; that's why I left the comparison in.
> 
> (e.g. "md512345678901234567890123456789012zzz" would pass without strlen).

That's a hard morning...  Yes you are right and I can see the failure.
By the way, grouping everything in one patch looks more adapted to me
as this tightens all the checks for the different verifier types.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190423021018.GF2712@paquier.xyz/2-signature.asc)
  download

view thread (27+ messages)  latest in thread

Message-ID: <20190423021018.GF2712@paquier.xyz>
Permalink:  ../20190423021018.GF2712@paquier.xyz/
Also on:    postgresql.org/message-id/20190423021018.GF2712@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, jkatz@postgresql.org, tgl@sss.pgh.pa.us, sfrost@snowman.net
  Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords
  In-Reply-To: <20190423021018.GF2712@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox