From: Andres Freund <andres@anarazel.de>
To: jungleboogie0@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Sat, 17 Aug 2019 13:33:34 -0700
Message-ID: <20190817203334.arnlbvxaaqfhycaz@alap3.anarazel.de> (raw)
In-Reply-To: <15964-c1753bdfed722e04@postgresql.org>
References: <15964-c1753bdfed722e04@postgresql.org>
Hi,
On 2019-08-17 19:06:33 +0000, PG Bug reporting form wrote:
> I'm trying to compile Postgresql from master on my OpenBSD machine, but I'm
> getting a build failure here:
> vacuumdb.c:184:26: error: use of undeclared identifier 'FD_SETSIZE'
> if (concurrentCons > FD_SETSIZE - 1)
> ^
> vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
> FD_SETSIZE
> - 1);
> ^
> 2 errors generated.
Yea, that file is clearly missing an include for #include
<sys/select.h>. I don't immediately see how that file is included on
other platforms, but it's obviously not enough for your version of
openbsd.
I assume adding
#ifdef HAVE_SYS_SELECT_H
#include <sys/select.h>
#endif
after
#include "postgres_fe.h"
in vacuumdb.c fixes the problem?
Michael, it looks like this is an oversight in
commit 5f3840370b63fdf17f704a285623ccc233fa8d4f
Author: Michael Paquier <michael@paquier.xyz>
Date: 2019-07-19 09:31:58 +0900
Refactor parallelization processing code in src/bin/scripts/
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: andres@anarazel.de, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
In-Reply-To: <20190817203334.arnlbvxaaqfhycaz@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox