pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: cilizili@protonmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16082: TOAST's pglz_decompress access to uninitialized data, if  the database is corrupted.
Date: Wed, 30 Oct 2019 17:30:14 -0300
Message-ID: <20191030203014.GA5452@alvherre.pgsql> (raw)
In-Reply-To: <20191026215646.5e2brazqzboxclf4@development>

On 2019-Oct-26, Tomas Vondra wrote:

> On Sat, Oct 26, 2019 at 07:46:25AM +0000, PG Bug reporting form wrote:

> > There is two case that they are valid for invalid data. In the case 1, it
> > reads an uninitialized data in the dest. In the case 2, it reads
> > uninitialized or out-of-bound data in the dest. They are invalid.

> Well, failure like this after reading corrupted data from disk is not
> really surprising and it's hardly a bug. It's kinda intended to work
> that way, really.

There's some weight to the argument that the server should just crash
but instead report an ERRCODE_DATA_CORRUPTED message, such as what
happens with (say) invalid page headers.  It would probably require a
lot more branches in the detoasting code that might decrease
performance, though.  A patch would help to see how bad that would be,
though offhand I would expect it to be very bad.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (4+ messages)  latest in thread

Message-ID: <20191030203014.GA5452@alvherre.pgsql>
Permalink:  ../20191030203014.GA5452@alvherre.pgsql/
Also on:    postgresql.org/message-id/20191030203014.GA5452@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@2ndquadrant.com, tomas.vondra@2ndquadrant.com, cilizili@protonmail.com
  Subject: Re: BUG #16082: TOAST's pglz_decompress access to uninitialized data, if  the database is corrupted.
  In-Reply-To: <20191030203014.GA5452@alvherre.pgsql>
  References: <20191026215646.5e2brazqzboxclf4@development> <20191030203014.GA5452@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox