pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: basil.bourque@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: BUG #15912: The units of `autovacuum_vacuum_cost_delay` setting should be documented
Date: Tue, 5 Nov 2019 15:11:45 -0500
Message-ID: <20191105201145.GB32473@momjian.us> (raw)
In-Reply-To: <15882.1571942223@sss.pgh.pa.us>
References: <C6E10B26-97E0-4B4D-9AEE-E26A7E2263F9@yesql.se>
	<20190726220242.GA16906@alvherre.pgsql>
	<20190727214130.bjgyv2holjng3oeb@momjian.us>
	<20191009014955.GA3191@momjian.us>
	<15882.1571942223@sss.pgh.pa.us>

On Thu, Oct 24, 2019 at 02:37:03PM -0400, Tom Lane wrote:
> I think this is confusingly bad English, and it's poor exposition
> because a minor detail (it must be pretty minor, if we got away
> without mentioning it at all for years) is injected into the middle
> of the basic statement of the variable's purpose.  I think what we'd
> be better off doing is to write a separate sentence mentioning the
> units, in more or less the same way that we generally handle the
> default value.  In <14850.1571941169@sss.pgh.pa.us> I suggested
> this revision for statement_timeout:
> 
>         Abort any statement that takes more than the specified duration.
>         If <varname>log_min_error_statement</varname> is set
>         to <literal>ERROR</literal> or lower, the statement that timed out
>         will also be logged.
>         If the value is specified as a plain number, it is measured in
>         milliseconds by default.
>         A value of zero (the default) disables the timeout.
> 
> (I'm not quite sure whether the ending "by default" is worth writing
> or not.)
> 
> Barring objections, I'll run around and make them all look like that.

Thanks for applying the improvement in your patch cfb7559083.  I was
torn between it being a minor issue and not wanting to devote a new
sentence about it, which is why I awkwardly used parentheses.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +





view thread (7+ messages)

Message-ID: <20191105201145.GB32473@momjian.us>
Permalink:  ../20191105201145.GB32473@momjian.us/
Also on:    postgresql.org/message-id/20191105201145.GB32473@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, daniel@yesql.se, basil.bourque@gmail.com, pgsql-docs@lists.postgresql.org
  Subject: Re: BUG #15912: The units of `autovacuum_vacuum_cost_delay` setting should be documented
  In-Reply-To: <20191105201145.GB32473@momjian.us>
  References: <C6E10B26-97E0-4B4D-9AEE-E26A7E2263F9@yesql.se> <20190726220242.GA16906@alvherre.pgsql> <20190727214130.bjgyv2holjng3oeb@momjian.us> <20191009014955.GA3191@momjian.us> <15882.1571942223@sss.pgh.pa.us> <20191105201145.GB32473@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox