From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Reorderbuffer crash during recovery
Date: Thu, 7 Nov 2019 12:18:23 +0100
Message-ID: <20191107111823.ujkygoo562nngnza@development> (raw)
In-Reply-To: <CAFiTN-sT6QdUptzifxc8ZCjsnvuJKiLhG6K4s_2=asX76B6nQQ@mail.gmail.com>
References: <CALDaNm2CLk+K9JDwjYST0sPbGg5AQdvhUt0jbKyX_HdAE0jk3A@mail.gmail.com>
<CAFiTN-vb69GF-BMWy8G56_VDW5qJbCS2_mvNgiDRjUfzNB0Dkw@mail.gmail.com>
<CALDaNm0HLJe6cE4+GA-vKiF3CbMKjRzH9S1-RtFdYfPqR0opgQ@mail.gmail.com>
<CAFiTN-sT6QdUptzifxc8ZCjsnvuJKiLhG6K4s_2=asX76B6nQQ@mail.gmail.com>
On Thu, Nov 07, 2019 at 11:01:17AM +0530, Dilip Kumar wrote:
>On Thu, Nov 7, 2019 at 9:55 AM vignesh C <vignesh21@gmail.com> wrote:
>>
>> On Wed, Nov 6, 2019 at 5:41 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>> >
>> > On Wed, Nov 6, 2019 at 5:20 PM vignesh C <vignesh21@gmail.com> wrote:
>> > >
>> > > Hi,
>> > >
>> > > ...
>> > >
>> > > Issue1 it seems like if all the reorderbuffer has been flushed and
>> > > then the server restarts. This problem occurs.
>> > > Issue 2 it seems like if there are many subtransactions present and
>> > > then the server restarts. This problem occurs. The subtransaction's
>> > > final_lsn is not being set and when ReorderBufferRestoreCleanup is
>> > > called the assert fails. May be for this we might have to set the
>> > > subtransaction's final_lsn before cleanup(not sure).
>> > >
>> > > I could not reproduce this issue consistently with a test case, But I
>> > > felt this looks like a problem from review.
>> > >
>> > > For issue1, I could reproduce by the following steps:
>> > > 1) Change ReorderBufferCheckSerializeTXN so that it gets flushed always.
>> > > 2) Have many open transactions with subtransactions open.
>> > > 3) Attach one of the transaction from gdb and call abort().
>> >
>> > Do you need subtransactions for the issue1? It appears that after the
>> > restart if the changes list is empty it will hit the assert. Am I
>> > missing something?
>> >
>>
>> When I had reported this issue I could reproduce this issue with
>> sub-transactions. Now I have tried without using sub-transactions and
>> could still reproduce this issue. You are right Issue 1 will appear in
>> both the cases with and without subtransactions.
>
>Okay, thanks for the confirmation.
>
I'm a bit confused - does this happen only with the logical_work_mem
patches, or with clean master too? If only with the patches, which
version exactly?
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, dilipbalaut@gmail.com, vignesh21@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Reorderbuffer crash during recovery
In-Reply-To: <20191107111823.ujkygoo562nngnza@development>
References: <CALDaNm2CLk+K9JDwjYST0sPbGg5AQdvhUt0jbKyX_HdAE0jk3A@mail.gmail.com> <CAFiTN-vb69GF-BMWy8G56_VDW5qJbCS2_mvNgiDRjUfzNB0Dkw@mail.gmail.com> <CALDaNm0HLJe6cE4+GA-vKiF3CbMKjRzH9S1-RtFdYfPqR0opgQ@mail.gmail.com> <CAFiTN-sT6QdUptzifxc8ZCjsnvuJKiLhG6K4s_2=asX76B6nQQ@mail.gmail.com> <20191107111823.ujkygoo562nngnza@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox