pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Floris Van Nee <florisvannee@Optiver.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: Ferdi Smit <FerdiSmit@Optiver.com>
Cc: Stephen Frost <sfrost@snowman.net>
Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly
Date: Mon, 18 Nov 2019 12:10:59 +0900
Message-ID: <20191118031059.GA1543@paquier.xyz> (raw)
In-Reply-To: <1574024173786.96623@Optiver.com>
References: <1573808483712.96817@Optiver.com>
	<29913.1573835973@sss.pgh.pa.us>
	<1574024173786.96623@Optiver.com>

On Sun, Nov 17, 2019 at 08:56:13PM +0000, Floris Van Nee wrote:
> As for the proper fix, indeed it looks like the 'drop role' needs to
> be taught to update pg_init_privs.

The dependencies related to the ACL entries exist in pg_shdepend
between the role and the revoked objects, and these get removed when
issuing DROP OWNED BY.  So it seems to me that the cleanup needs to
happen when issuing the DROP OWNED BY query, and not DROP ROLE.
Looking at the code, it seems to me that we should just patch
shdepDropOwned() to handle properly the removal of the role in ACL
objects in pg_init_privs for all the objects we are removing a
dependency on.  I am just diving into a patch..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (14+ messages)  latest in thread

Message-ID: <20191118031059.GA1543@paquier.xyz>
Permalink:  ../20191118031059.GA1543@paquier.xyz/
Also on:    postgresql.org/message-id/20191118031059.GA1543@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, florisvannee@Optiver.com, tgl@sss.pgh.pa.us, FerdiSmit@Optiver.com, sfrost@snowman.net
  Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly
  In-Reply-To: <20191118031059.GA1543@paquier.xyz>
  References: <1573808483712.96817@Optiver.com> <29913.1573835973@sss.pgh.pa.us> <1574024173786.96623@Optiver.com> <20191118031059.GA1543@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox