pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: starbugs@qq.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16190: The usage of NULL pointer in refint.c
Date: Mon, 6 Jan 2020 15:49:18 +0900
Message-ID: <20200106064918.GS3598@paquier.xyz> (raw)
In-Reply-To: <1234.1578291695@sss.pgh.pa.us>
References: <16190-70181c803641c3dc@postgresql.org>
	<20200106051800.GL3598@paquier.xyz>
	<1234.1578291695@sss.pgh.pa.us>

On Mon, Jan 06, 2020 at 01:21:35AM -0500, Tom Lane wrote:
> Yeah, if somebody wanted to fix this, the right way is to replace
> these malloc calls with pallocs.  Some investigation would be needed
> about which context to use.

It seems to me that this would be TopMemoryContext.  All the plans
used for the checks are kept within the context of the session.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (11+ messages)  latest in thread

Message-ID: <20200106064918.GS3598@paquier.xyz>
Permalink:  ../20200106064918.GS3598@paquier.xyz/
Also on:    postgresql.org/message-id/20200106064918.GS3598@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, starbugs@qq.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16190: The usage of NULL pointer in refint.c
  In-Reply-To: <20200106064918.GS3598@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox