From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jobin Augustine <jobinau@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: libpq parameter parsing problem
Date: Thu, 16 Jan 2020 12:49:17 +0900
Message-ID: <20200116034917.GD3117@paquier.xyz> (raw)
In-Reply-To: <fe1a7b9f-5630-00dd-3780-1b150a583fdf@2ndquadrant.com>
References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com>
<CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com>
<CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com>
<22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi>
<20200109043809.GK2251@paquier.xyz>
<CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com>
<20200114060317.GF1515@paquier.xyz>
<fe1a7b9f-5630-00dd-3780-1b150a583fdf@2ndquadrant.com>
On Wed, Jan 15, 2020 at 04:42:28PM +0100, Peter Eisentraut wrote:
> Let's please not put links to Wikipedia into the main body of the
> documentation. If people want to look up something, they know where to find
> it.
That's not really a new concept:
$ cd doc/ && git grep wikipedia\.org | wc -l
55
> Links to authoritative sources (perhaps an RFC in this case) would be
> better.
No objections to your suggestion in this case though. I can see
Section 2.1 from RFC3986 for that:
https://tools.ietf.org/html/rfc3986#section-2.1
So, gathering all the feedback and my own tweaks, I finish with the
attached (merely simplified).
--
Michael
Attachments:libpqURIconnection_v3.diff (text/x-diff, 968B) downloaddiff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgmlindex 64cff49c4d..348cb0e866 100644--- a/doc/src/sgml/libpq.sgml+++ b/doc/src/sgml/libpq.sgml@@ -925,10 +925,15 @@ postgresql:///mydb?host=localhost&port=5433
</para>
<para>
- Percent-encoding may be used to include symbols with special meaning in any- of the <acronym>URI</acronym> parts, e.g. replace <literal>=</literal> with- <literal>%3D</literal>.-+ Connection <acronym>URI</acronym> needs to be encoded with + <ulink url="https://tools.ietf.org/html/rfc3986#section-2.1">Percent-encoding</ulink> + if it includes symbols with special meaning in any of its parts. + Here is an example where <literal>=</literal> is replaced with+ <literal>%3D</literal> and whitespace character with+ <literal>%20</literal>:+<programlisting>+postgresql://user@localhost:5433/mydb?options=-c%20synchronous_commit%3Doff+</programlisting>
</para>
<para>
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, jobinau@gmail.com, hlinnaka@iki.fi, oleksandr.shulgin@zalando.de
Subject: Re: libpq parameter parsing problem
In-Reply-To: <20200116034917.GD3117@paquier.xyz>
References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com> <CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com> <CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com> <22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi> <20200109043809.GK2251@paquier.xyz> <CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com> <20200114060317.GF1515@paquier.xyz> <fe1a7b9f-5630-00dd-3780-1b150a583fdf@2ndquadrant.com> <20200116034917.GD3117@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox