From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marc Munro <marc@bloodnok.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_dump No comment for policy
Date: Tue, 17 Mar 2020 22:19:18 -0400
Message-ID: <20200318021918.GA28233@momjian.us> (raw)
In-Reply-To: <8932.1581962377@sss.pgh.pa.us>
References: <1581889298.18009.15.camel@bloodnok.com>
<8932.1581962377@sss.pgh.pa.us>
On Mon, Feb 17, 2020 at 12:59:37PM -0500, Tom Lane wrote:
> Marc Munro <marc@bloodnok.com> writes:
> > I have created a policy with a comment on it. pg_dump does not dump
> > the comment.
>
> Ugh, yeah, there's no dumpComment() call in dumpPolicy().
>
> Easy enough to fix, but now I wonder if we missed the same elsewhere.
FYI, this was fixed on February 17 and will appear in the next minor
release:
commit f31364676d
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon Feb 17 18:40:02 2020 -0500
Teach pg_dump to dump comments on RLS policy objects.
This was unaccountably omitted in the original RLS patch.
The SQL syntax is basically the same as for comments on triggers,
so crib code from dumpTrigger().
Per report from Marc Munro. Back-patch to all supported branches.
Discussion: https://postgr.es/m/1581889298.18009.15.camel@bloodnok.com
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, marc@bloodnok.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_dump No comment for policy
In-Reply-To: <20200318021918.GA28233@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox