From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: hghwng@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
Date: Tue, 31 Mar 2020 10:52:59 -0300
Message-ID: <20200331135259.GA29443@alvherre.pgsql> (raw)
In-Reply-To: <20200331072153.GB1549@paquier.xyz>
On 2020-Mar-31, Michael Paquier wrote:
> On Mon, Mar 30, 2020 at 12:48:51PM -0300, Alvaro Herrera wrote:
> > On 2020-Mar-30, Tom Lane wrote:
> >> It looks to me like there's a similar hazard a bit further down
> >> (line 3029):
> >>
> >> appendConnStrVal(&connstr, PQdb(o_conn));
> >>
> >> I wonder if we should force reuse_previous to false if there's
> >> no o_conn, rather than fixing this stuff piecemeal.
> >
> > That was my impression too.
>
> Good point. What do you think about the attached then?
Looks better :-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, hghwng@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
In-Reply-To: <20200331135259.GA29443@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox