From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Date: Wed, 22 Apr 2020 00:41:21 +0200
Message-ID: <20200422004121.516a5a32@firost> (raw)
In-Reply-To: <20200421021501.GE77439@paquier.xyz>
References: <20200417065043.GC350229@paquier.xyz>
<20200417153304.01a226cc@firost>
<20200418092611.GD350229@paquier.xyz>
<20200420.160231.719176619682386260.horikyota.ntt@gmail.com>
<20200420073444.GA77439@paquier.xyz>
<20200420142235.1536a73b@firost>
<20200421021501.GE77439@paquier.xyz>
Hello,
I did another round of review of v8.
- LocalRecoveryInProgress = xlogctl->SharedRecoveryInProgress;
+ LocalRecoveryInProgress = (xlogctl->SharedRecoveryState !=
RECOVERY_STATE_DONE);
Do we need to acquire info_lck to look at the state here, as we do in
GetRecoveryState()? Why is it missing from previous code where
SharedRecoveryInProgress was protected by info_lck as well?
Plus, the new line length overflow the 80-column, but I'm not sure where to
break this line.
+if ($Config{osname} eq 'MSWin32')
+{
+
+ # some Windows Perls at least don't like IPC::Run's start/kill_kill
regime.
+ plan skip_all => "Test fails on Windows perl";
+}
In fact, this was inherited from 011_crash_recovery.pl where I originally
added some tests. As 020_archive_status.pl doesn't use IPC::Run, the comment is
wrong. But I wonder if this whole block is really needed. Unfortunately I can't
test on MSWin32 :/
On Tue, 21 Apr 2020 11:15:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> > Indeed, Benoît Lobréau reported this behavior to me.
>
> Noted. Thanks for the information. I don't think that I have ever
> met Benoît in person, do I?
I don't think so.
> Tell him that I owe him one beer or a beverage of his choice when we meet
> IRL, and that he had better use this message-id to make me keep my promise :)
I told him (but I'm sure he was reading anyway :)).
Regards,
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jgdr@dalibo.com, michael@paquier.xyz, horikyota.ntt@gmail.com, masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
In-Reply-To: <20200422004121.516a5a32@firost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox