pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: ram.maurya@lavainternational.in, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
Date: Thu, 18 Jun 2020 11:29:11 -0400
Message-ID: <20200618152911.GF7349@momjian.us> (raw)
In-Reply-To: <1549966.1592493410@sss.pgh.pa.us>
References: <16497-38bb1f1bcec44964@postgresql.org>
	<20200618080509.GH118592@paquier.xyz>
	<CAMkU=1zRirCC-kZTZb0hBq+jqy7vjk8+ehbrZpjr5LATKFChKQ@mail.gmail.com>
	<1549966.1592493410@sss.pgh.pa.us>

On Thu, Jun 18, 2020 at 11:16:50AM -0400, Tom Lane wrote:
> Jeff Janes <jeff.janes@gmail.com> writes:
> > Since wal-segsize is changeable with pg_resetwal since v11, and pg_upgrade
> > is already calling pg_resetwal, shouldn't pg_upgrade ideally just deal with
> > this situation automatically by allowing the upgrade to also change this
> > value, rather than forcing the user to make them match manually?
> 
> The issue is that this is an initdb parameter, and pg_upgrade expects you
> to have already initdb'd the destination cluster.  We could redefine that,
> perhaps, but it'd be a large change in how one uses pg_upgrade and would
> certainly break a lot of scripts.
> 
> I'm aware that we could use pg_resetwal to deal with this one specific
> initdb parameter, but I see no point in hacking around the problem for
> just one parameter.  The general principle remains that you need to
> initdb the target with the same settings you used for the source.

Yep, that's pretty much the issue.  :-)

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee






view thread (25+ messages)  latest in thread

Message-ID: <20200618152911.GF7349@momjian.us>
Permalink:  ../20200618152911.GF7349@momjian.us/
Also on:    postgresql.org/message-id/20200618152911.GF7349@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, jeff.janes@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match
  In-Reply-To: <20200618152911.GF7349@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox