From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robins Tharakan <tharakan@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: ALTER TABLE ALTER COLUMN SET TYPE crash
Date: Tue, 25 Aug 2020 13:35:11 -0400
Message-ID: <20200825173511.GA20679@momjian.us> (raw)
In-Reply-To: <2745154.1598372060@sss.pgh.pa.us>
References: <CAEP4nAzwokLht2Bi3RCHNcCJBdOa8d7LnqJkDO1xiaH+biW8fw@mail.gmail.com>
<20200825060511.GF2017@paquier.xyz>
<20200825155544.GG32540@momjian.us>
<2745154.1598372060@sss.pgh.pa.us>
On Tue, Aug 25, 2020 at 12:14:20PM -0400, Tom Lane wrote:
> I think the nature of the problem (and Robins' other report too) is pretty
> clear. We have a SQL or plpgsql function that's trying to access a table
> that is inconsistent during an ALTER TABLE operation. The function would
> be locked out from seeing that transient state if it were in another
> session, thanks to normal locking rules; but the lock acquisition rules
> don't prevent same-session accesses.
>
> ALTER TABLE and related utility commands contain guards against the
> reverse form of this problem: CheckTableNotInUse will bitch if there's
> some already-active outer query referencing the table. But we haven't
> thought about the possibility of one of these commands executing
> user-defined code midway through.
That does explain why it fails on the _second_ time through those
lower-level functions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, michael@paquier.xyz, tharakan@gmail.com
Subject: Re: ALTER TABLE ALTER COLUMN SET TYPE crash
In-Reply-To: <20200825173511.GA20679@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox