From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: jan.mussler@zalando.de
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message.
Date: Mon, 31 Aug 2020 21:25:53 -0400
Message-ID: <20200901012553.GA17180@alvherre.pgsql> (raw)
In-Reply-To: <20200829013433.GA1529@paquier.xyz>
On 2020-Aug-29, Michael Paquier wrote:
> On Fri, Aug 28, 2020 at 08:22:42AM +0900, Michael Paquier wrote:
> > Yes, adding that to RemoveRelations() makes sense. Thanks for the
> > patch.
>
> I got some room to test the patch, and the place of the check looks
> good to me. I think that I would move the new check before we set
> PERFORM_DELETION_CONCURRENTLY for non-temporary relations though, as a
> partition tree can be temporary as long as all its members are
> temporary.
Actually I think you're wrong; if I put it before the check, then if I
do "drop index concurrently some_temp_partitioned_index" then it would
fail; but if I put it after the check, then it does a normal
non-concurrent index and it works. I'm not sure it's necessary to break
a case that otherwise works ...
(But for that to work I need to test the flag in the bitmask rather than
the option in the command, as in the attached).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
v2-0001-Raise-error-on-concurrent-drop-of-partitioned-ind.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, jan.mussler@zalando.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message.
In-Reply-To: <20200901012553.GA17180@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox