pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Date: Thu, 3 Sep 2020 21:21:49 -0400
Message-ID: <20200904012149.GA13932@momjian.us> (raw)
In-Reply-To: <CAKFQuwb_3yNTTE6cG_YtXFtV=CkQf0uMSMB0oxC1YNrF94pfuA@mail.gmail.com>
References: <16419-d8d9db0a7553f01b@postgresql.org>
	<CAKFQuwYPjq=UAHNZ6KtHuJPA8pmttV3X+imFYcBQqNUGWsCexg@mail.gmail.com>
	<AM0PR03MB3570F99911704BFC77294DA1BFA50@AM0PR03MB3570.eurprd03.prod.outlook.com>
	<CAKFQuwaXESne_VYt8bE8L5gGGqEM0TCGL+JNL1a8NJ2_uc8VfQ@mail.gmail.com>
	<CAKFQuwajC7+s-nHRujP+w5GsUTcp8usazdPas59Kz3kCTq+e3w@mail.gmail.com>
	<0123b852ae3fe53eca11b9451d035411b06dafd5.camel@cybertec.at>
	<CAKFQuwb_3yNTTE6cG_YtXFtV=CkQf0uMSMB0oxC1YNrF94pfuA@mail.gmail.com>

On Wed, Jul 15, 2020 at 09:26:53AM -0700, David G. Johnston wrote:
> On Tue, May 12, 2020 at 8:56 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
>     On Tue, 2020-05-12 at 18:09 -0700, David G. Johnston wrote:
>     > Redirecting to -hackers for visibility.  I feel there needs to be
>     something done here, even if just documentation (a bullet in the usage
>     notes section - and a code comment update for the macro)
>     > pointing this out and not changing any behavior.
> 
>     Since "to_date" is an Oracle compatibility function, here is what Oracle
>     18.4 has to say to that:
> 
>     SQL> SELECT to_date('0000', 'YYYY') FROM dual;
>     SELECT to_date('0000', 'YYYY') FROM dual
>                    *
>     ERROR at line 1:
>     ORA-01841: (full) year must be between -4713 and +9999, and not be 0
> 
> 
> 
> Attached is a concrete patch (back-patchable hopefully) documenting the current
> reality.
> 
> As noted in the patch commit message (commentary really):
> 
> make_timestamp not agreeing with make_date on how to handle negative years
> should probably just be fixed - but that is for someone else to handle.
> 
> Whether to actually change the behavior of to_date is up for debate though I
> would presume it would not be back-patched.

OK, so, looking at this thread, we have to_date() treating -1 as -2 BC,
make_date() treating -1 as 1 BC, and we have Oracle, which to_date() is
supposed to match, making -1 as 1 BC.

Because we already have the to_date/make_date inconsistency, and the -1
to -2 BC mapping is confusing, and doesn't match Oracle, I think the
clean solution is to change PG 14 to treat -1 as 1 BC, and document the
incompatibility in the release notes.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee






view thread (31+ messages)  latest in thread

Message-ID: <20200904012149.GA13932@momjian.us>
Permalink:  ../20200904012149.GA13932@momjian.us/
Also on:    postgresql.org/message-id/20200904012149.GA13932@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bruce@momjian.us, david.g.johnston@gmail.com, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
  Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
  In-Reply-To: <20200904012149.GA13932@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox