From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG v13] Crash with event trigger in extension
Date: Fri, 4 Sep 2020 16:56:58 +0200
Message-ID: <20200904165658.3c57fa4a@firost> (raw)
In-Reply-To: <20200904132715.GA5969@alvherre.pgsql>
References: <20200904113728.2d4a44bb@firost>
<20200904132715.GA5969@alvherre.pgsql>
On Fri, 4 Sep 2020 09:27:15 -0400
Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2020-Sep-04, Jehan-Guillaume de Rorthais wrote:
>
> > Indeed, it's much more simple and cheaper. However, the result is a bit
> > confusing as it's not a wrong SQL result, but the backend that actually
> > crash. The crash message itself appears in results/test_extensions.out, but
> > no other tests are run. Neither from the same SQL file or from other ones.
> > That Means the diff is quite large, but the error appears close from the
> > top.
>
> Oh! If it crashes without the extension, then we don't *need* the
> exension and surely we don't need the test to be in src/test/modules/;
Oh wait. It's not what I meant. We *need* an extension to trigger the
backend crash.
> my inclination would be to put it somewhere in
> src/test/regress/sql/event_triggers.sql, maybe at the bottom, with a
> comment that references this thread.
As the regression need an extension to be installed, it still makes sens to
test from src/test/modules/test_extension where various extensions are
installed to run the checks.
Please find in attachment patch v3.
Attachments:
v3-0001-Fix-crash-with-alter-table-event-triggers-in-extensi.patch (text/x-patch, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jgdr@dalibo.com, alvherre@2ndquadrant.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG v13] Crash with event trigger in extension
In-Reply-To: <20200904165658.3c57fa4a@firost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox