pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace
Date: Thu, 15 Oct 2020 12:19:59 -0300
Message-ID: <20201015151959.GA6823@alvherre.pgsql> (raw)
In-Reply-To: <20200908235553.7tbd6xjvnohv2xel@development>

On 2020-Sep-09, Tomas Vondra wrote:

> On Tue, Sep 08, 2020 at 06:37:29PM -0300, Alvaro Herrera wrote:
> > On 2020-Sep-08, Michael Paquier wrote:
> > 
> > > On Tue, Aug 11, 2020 at 04:04:07PM +0900, Michael Paquier wrote:
> > > > Hmm.  Creating a file for partitioned table would be a completely new
> > > > thing as well.  heap_create() has never created a file for partitioned
> > > > tables since 10 so this could open to a new class of bugs.
> > > 
> > > This thread has stalled for a couple of weeks now, and I would tend to
> > > take the path where we'd basically revert 8725958 and ca41030.  That's
> > > too late for v13 to do anything about that.  But not for 14.  Any
> > > opinions?
> > 
> > Well, naturally I oppose this idea.
> 
> Would it actually solve the issue? ISTM we'd still have to expect cases
> with partitioned tables without storage, so presumably we'd have to do
> something else ...

It just dawned on me that a way to fix this is to use a pg_shdepend
entry to protect the tablespace from being dropped.





view thread (22+ messages)  latest in thread

Message-ID: <20201015151959.GA6823@alvherre.pgsql>
Permalink:  ../20201015151959.GA6823@alvherre.pgsql/
Also on:    postgresql.org/message-id/20201015151959.GA6823@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tomas.vondra@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace
  In-Reply-To: <20201015151959.GA6823@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox