pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: rekgrpth@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17035: assert after commit
Date: Wed, 26 May 2021 13:40:17 -0400
Message-ID: <20210526174017.GA11909@alvherre.pgsql> (raw)
In-Reply-To: <1453294.1622037151@sss.pgh.pa.us>

On 2021-May-26, Tom Lane wrote:

> PG Bug reporting form <noreply@postgresql.org> writes:
> > after this commit
> > https://github.com/postgres/postgres/commit/d18ee6f92d9a22b4fae57f515797b2196bf385c7
> > I got assert
> > TRAP: FailedAssertion("portal != NULL", File: "pquery.c", Line: 1758)
> > in my plugin
> > https://github.com/RekGRpth/pg_task
> 
> I'm inclined to think that means you were doing something you
> should not have been doing.  But without any details it's
> hard to say.

Hmm, see for example [1] which is doing SPI_prepare_my() [2] and then
SPI_execute_plan_my() ... Does the SPI interface really require that you
create an ActivePortal in the SPI-calling code?  This looks a bit
suspicious to me ...

[1] https://github.com/RekGRpth/pg_task/blob/master/work.c#L703
[2] https://github.com/RekGRpth/pg_task/blob/master/spi.c

-- 
Álvaro Herrera       Valdivia, Chile





view thread (8+ messages)  latest in thread

Message-ID: <20210526174017.GA11909@alvherre.pgsql>
Permalink:  ../20210526174017.GA11909@alvherre.pgsql/
Also on:    postgresql.org/message-id/20210526174017.GA11909@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17035: assert after commit
  In-Reply-To: <20210526174017.GA11909@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox