From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Petr Fedorov <petr.fedorov@phystech.edu>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch
Date: Mon, 7 Jun 2021 22:31:55 -0700
Message-ID: <20210608053155.GB444080@rfd.leadboat.com> (raw)
In-Reply-To: <660576.1623006607@sss.pgh.pa.us>
References: <428767b1-6a18-cc5a-bb2f-a78bc306fae3@postgresfriends.org>
<6816.1590426450@sss.pgh.pa.us>
<7994.1590428104@sss.pgh.pa.us>
<298489.1604188643@sss.pgh.pa.us>
<829899.1604357408@sss.pgh.pa.us>
<1090402.1604449334@sss.pgh.pa.us>
<20210606063331.GC297923@rfd.leadboat.com>
<633566.1622990278@sss.pgh.pa.us>
<650852.1622997506@sss.pgh.pa.us>
<660576.1623006607@sss.pgh.pa.us>
On Sun, Jun 06, 2021 at 03:10:07PM -0400, Tom Lane wrote:
> I wrote:
> > We could make use of COMPARE_COERCIONFORM_FIELD 100% correct by removing
> > these two tests of the funcformat value, but on the whole I doubt that
> > would be better.
>
> On still closer inspection, that seems like it'd be fine. All of
> the gram.y productions that emit COERCE_SQL_SYNTAX also produce
> schema-qualified function names (via SystemFuncName); and it seems
> hard to see a use-case where we'd not do that. This makes the two
> checks I cited 100% redundant, because the conditions they are in
> also insist on an unqualified function name. So let's just take them
> out again, making it strictly OK to use COMPARE_COERCIONFORM_FIELD.
I have little intuition on this exact topic, but I have no particular concerns
about the change you pushed.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, vik@postgresfriends.org, thomas.munro@gmail.com, petr.fedorov@phystech.edu, pgsql-hackers@postgresql.org
Subject: Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch
In-Reply-To: <20210608053155.GB444080@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox