From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default
Date: Mon, 14 Jun 2021 15:13:21 -0400
Message-ID: <202106141913.cbzfrrcoinxx@alvherre.pgsql> (raw)
In-Reply-To: <759e997e-e1ca-91cd-84db-f4ae963fada1@dunslane.net>
On 2021-Jun-12, Andrew Dunstan wrote:
> + /* Don't do anything unless it's a RELKIND type relation */
> + if (tablerel->rd_rel->relkind != RELKIND_RELATION)
> + {
> + table_close(tablerel, AccessExclusiveLock);
> + return;
> + }
"RELKIND type relation" is the wrong phrase ... maybe "it's a plain
table" is good enough? (Ditto in RelationBuildTupleDesc).
> /*
> * Here we go --- change the recorded column type and collation. (Note
> * heapTup is a copy of the syscache entry, so okay to scribble on.) First
> - * fix up the missing value if any.
> + * fix up the missing value if any. There shouldn't be any missing values
> + * for anything except RELKIND_RELATION relations, but if there are, ignore
> + * them.
> */
> - if (attTup->atthasmissing)
> + if (rel->rd_rel->relkind == RELKIND_RELATION && attTup->atthasmissing)
Would it be sensible to have a macro "AttributeHasMissingVal(rel,
attTup)", to use instead of reading atthasmissing directly? The macro
would check the relkind, and also serve as documentation that said check
is necessary.
--
Álvaro Herrera 39°49'30"S 73°17'W
"Uno puede defenderse de los ataques; contra los elogios se esta indefenso"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, andrew@dunslane.net, andres@anarazel.de, tgl@sss.pgh.pa.us, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default
In-Reply-To: <202106141913.cbzfrrcoinxx@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox