From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: lizenko79@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17073: docs - "Improve signal handling reliability"
Date: Wed, 30 Jun 2021 21:57:17 -0400
Message-ID: <202107010157.z24ttolwr55g@alvherre.pgsql> (raw)
In-Reply-To: <CAKFQuwbxrx5YnRniPBCkVb4hA12gQES0GNPofDN03L5gHzZN7g@mail.gmail.com>
On 2021-Jun-30, David G. Johnston wrote:
> On Wed, Jun 30, 2021 at 5:54 PM Fujii Masao <masao.fujii@oss.nttdata.com>
> wrote:
> > Since this explains the commit 2945a488a, it's better to describe
> > something like the following?
> The wording still needs some work...but is this even release note worthy?
>
> We forget to check for interrupts before sleeping in an otherwise busy-wait
> loop. We corrected the oversight.
Yeah, it's a good question. I wonder if this should be back-patched, so
it'd be noted as a bugfix in the next set of minors rather than as a new
feature for 14.
(It's not a busy-wait loop, just a sleep, unless I misunderstand.)
> Most of what I'm reading says this only impacted the startup of the standby
> process; normal operations already worked correctly. Is that correct?
Yes, because the change is in WaitForWALToBecomeAvailable().
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Right now the sectors on the hard disk run clockwise, but I heard a rumor that
you can squeeze 0.2% more throughput by running them counterclockwise.
It's worth the effort. Recommended." (Gerry Pourwelle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, david.g.johnston@gmail.com, masao.fujii@oss.nttdata.com, bruce@momjian.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17073: docs - "Improve signal handling reliability"
In-Reply-To: <202107010157.z24ttolwr55g@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox