From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: jeff.janes@gmail.com
Cc: mk@071.ovh
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
Date: Thu, 15 Jul 2021 22:49:11 -0400
Message-ID: <202107160249.fjlmpg6vu3j5@alvherre.pgsql> (raw)
In-Reply-To: <20210716.110500.137369520113769822.horikyota.ntt@gmail.com>
On 2021-Jul-16, Kyotaro Horiguchi wrote:
> It's because another checkpoint is running at the time the manual
> checkpoint just before is invoked. Two successive checkpoint hides
> the defect. The checkpoint works as the rendezvous point for the
> succeeding tests so I added another sync point instead of the manual
> checkpoint. The test in the attached correctly fails if _logSegNo
> were not updated by slot invalidation.
OK, I thought as much and tried to catch it in the act but couldn't.
Your explanation makes sense.
> By the way, about the previous version, XLByteToSeg is needed since
> KeepLogSeg doesn't advance _logSegNo, which is the wanted action
> here. The test in the attached fails if only KeepLogSeg is called
> again.
Oh, true.
> I confirmed that *the previous* version of the test works for Windows.
> (So there's no reason that the current version doesn't work.)
Great, thanks.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, horikyota.ntt@gmail.com, jeff.janes@gmail.com, mk@071.ovh, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
In-Reply-To: <202107160249.fjlmpg6vu3j5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox