pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: jeff.janes@gmail.com
Cc: mk@071.ovh
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
Date: Thu, 29 Jul 2021 17:19:24 -0400
Message-ID: <202107292119.l3ts46r3f2vc@alvherre.pgsql> (raw)
In-Reply-To: <20210729.165007.1956564330541804824.horikyota.ntt@gmail.com>

On 2021-Jul-29, Kyotaro Horiguchi wrote:

> At Thu, 29 Jul 2021 16:20:38 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > So it seems to me we need to explicitly prevent unexpected checkpoints
> > from happening maybe by enlarging max_wal_size temporily.
> 
> I ended up with the attached. It causes a checkpoint reliably exactly
> at the aimed timing without.

Thanks for looking into it.  The explanation makes sense, so I pushed
your patch and also fixed one outdated comment I noticed while reading
the related code.  I hope this commit will solve the problem ... it is
quite low probability, so we'll have to wait at least two weeks to make
any conclusion.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/





view thread (27+ messages)  latest in thread

Message-ID: <202107292119.l3ts46r3f2vc@alvherre.pgsql>
Permalink:  ../202107292119.l3ts46r3f2vc@alvherre.pgsql/
Also on:    postgresql.org/message-id/202107292119.l3ts46r3f2vc@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, jeff.janes@gmail.com, mk@071.ovh, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
  In-Reply-To: <202107292119.l3ts46r3f2vc@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox