From: Noah Misch <noah@leadboat.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Date: Sun, 15 Aug 2021 01:45:35 -0700
Message-ID: <20210815084535.GA1227376@rfd.leadboat.com> (raw)
In-Reply-To: <20210814221328.GA146778@rfd.leadboat.com>
References: <20210730184126.GA2018234@gust.leadboat.com>
<D22DEA09-80DA-4350-839B-0FC0BD0668A4@yandex-team.ru>
<CAH2-Wz=Et8WLvS6d7-BH_yT9b5=cV89fXBmY0T-KgsT7R0=R_A@mail.gmail.com>
<85D32B53-FB25-4F2F-A253-0D7B26F72881@yandex-team.ru>
<DBD361BB-4327-4143-A849-36A262B22CEE@yandex-team.ru>
<341252AE-B633-471E-9FF4-B09FC5D036E2@yandex-team.ru>
<20210807221957.GA169359@rfd.leadboat.com>
<5E041A70-4946-489C-9B6D-764DF627A92D@yandex-team.ru>
<20210808163752.GB23176@rfd.leadboat.com>
<20210814221328.GA146778@rfd.leadboat.com>
On Sat, Aug 14, 2021 at 03:13:28PM -0700, Noah Misch wrote:
> On Sun, Aug 08, 2021 at 09:37:52AM -0700, Noah Misch wrote:
> > On Sun, Aug 08, 2021 at 04:31:07PM +0500, Andrey Borodin wrote:
> > > Step 1. Test for CIC with regular transactions.
> > > Step 2. Fix
> > > Step 3. Test for CIC with 2PC
> > > Step 4. Part of the fix that I'm sure about
> > > Step 5. Dubious part of fix...
>
> When I applied all five to commit b33259e^ (shortly before the PostgresNode
> compatibility break) and ran your tests in a loop, I got more 2PC "lacks
> matching index tuple" within one minute. Here's how I ran the tests:
>
> make -j20 && while make -C contrib/amcheck check REGRESS= PROVE_FLAGS=--timer PROVE_TESTS='t/002_cic.pl t/003_cic_2pc.pl' NO_TEMP_INSTALL=1; do date; done
>
> Do you see failures with that loop? If so, can you diagnose them?
See below.
> (So far, I've not seen a failure from the 1PC test.)
I eventually did see one. Just one 1PC failure in six hours of 1PC test
runtime, though.
> On Thu, Jul 29, 2021 at 10:25:48PM -0400, Noah Misch wrote:
> > I haven't checked whether other inval message types have the same hazard.
>
> I will look into this next. (It probably doesn't explain 2PC failures.)
Now that I've looked, other inval hazards might indeed explain the remaining
2PC and 1PC failures. I'll plug those holes and see what failures, if any,
continue to happen.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: noah@leadboat.com, x4mmm@yandex-team.ru, pgsql-bugs@lists.postgresql.org, michael@paquier.xyz, tgl@sss.pgh.pa.us, pg@bowt.ie
Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
In-Reply-To: <20210815084535.GA1227376@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox