pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Karina Litskevich <litskevichkarina@gmail.com>
Cc: 王海洋 <wanghaiyang.001@bytedance.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [PATCH] BUG FIX: inconsistent page found in BRIN_REGULAR_PAGE
Date: Fri, 23 Dec 2022 17:35:09 +0100
Message-ID: <20221223163509.rwxpzy6xfemppkxd@alvherre.pgsql> (raw)
In-Reply-To: <a5559c95-52c3-5eea-cd63-9b4f1c70ff96@gmail.com>

Hello,

On 2022-Dec-23, Karina Litskevich wrote:

> Is there any special reason to read WAL records until the last inserted
> record?

Hmm, no, there's no good reason to do it that way.

> It seems that in some rare situations on slower machines this test can fail.
> If any background process inserts a WAL record before lsn('insert')
> and this record isn't flushed before
> pg_get_wal_records_info('$start_lsn', '$end_lsn'),
> pg_get_wal_records_info('$start_lsn', '$end_lsn') ends with ERROR
> "cannot accept future end LSN" as it works only if record with end LSN
> is inserted.

Hmm.  I've never seen that, but it sounds plausible.

> I attached two patches with two ways of fixing this minor issue.

> -my $end_lsn = $whiskey->lsn('insert');
> +my $end_lsn = $whiskey->lsn('flush');

Thank you, I used this one.

Regards

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/





view thread (10+ messages)  latest in thread

Message-ID: <20221223163509.rwxpzy6xfemppkxd@alvherre.pgsql>
Permalink:  ../20221223163509.rwxpzy6xfemppkxd@alvherre.pgsql/
Also on:    postgresql.org/message-id/20221223163509.rwxpzy6xfemppkxd@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, litskevichkarina@gmail.com, wanghaiyang.001@bytedance.com, horikyota.ntt@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: [PATCH] BUG FIX: inconsistent page found in BRIN_REGULAR_PAGE
  In-Reply-To: <20221223163509.rwxpzy6xfemppkxd@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox