pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: xinwen@stu.scu.edu.cn
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c
Date: Sun, 12 Feb 2023 16:46:33 -0800
Message-ID: <20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de> (raw)
In-Reply-To: <CAApHDvrfuSuFq57EtbYxHNWYhMET9K_TpSefDUoM52-T6LCYbg@mail.gmail.com>
References: <17777-860b739b6efde977@postgresql.org>
	<20230210230230.scuk6gqrks6c7sc7@awork3.anarazel.de>
	<439391.1676070752@sss.pgh.pa.us>
	<20230210232051.efjhtoqo6odk3gke@awork3.anarazel.de>
	<443909.1676073430@sss.pgh.pa.us>
	<20230211004940.t5l2dz7rnss76zao@awork3.anarazel.de>
	<CAApHDvpeXSU4A=mzX=96Rdn6u4gjVLHy8SMaVm_g01S8yhfAoQ@mail.gmail.com>
	<842393.1676218781@sss.pgh.pa.us>
	<CAApHDvrfuSuFq57EtbYxHNWYhMET9K_TpSefDUoM52-T6LCYbg@mail.gmail.com>

Hi,

On 2023-02-13 13:31:54 +1300, David Rowley wrote:
> On Mon, 13 Feb 2023 at 05:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Why is it okay to check only the filter, and not the rest of the
> > WindowFunc's subexpressions?  The arguments we've just run through
> > seem to apply to a subplan in the direct or aggregated arguments
> > as well.
> 
> Good point.  I had just been thinking in terms of the reported bug to
> make sure we inverse transition the same rows we transition. We also
> need to make sure the transition value matches in both transition
> directions.

What about find_compatible_agg()? I don't think there's as severe
consequences, but it also doesn't seem right as-is.

Greetings,

Andres Freund





view thread (18+ messages)  latest in thread

Message-ID: <20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de>
Permalink:  ../20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: andres@anarazel.de, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c
  In-Reply-To: <20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox